This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Update GC heap range in StompWriteBarrier on ARM #18107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in #17851 JIT_CheckedWriteBarrier was not properly patched during
GCToEEInterface::StompWriteBarrier
whenoperation=WriteBarrierOp::StompResize
As consequence objects in higher generation sometime can miss cards on card table which causes objects in ephemeral ranges (assigned via JIT_CheckedWriteBarrier) be collected. Such situation is described in https://github.com/dotnet/coreclr/issues/17851#issuecomment-391206977
The problem manifest itself as intermittent segfaults in GC or WriteBarrier code and HeapVerify failures when
COMPlus_HeapVerify=1
. Affects both Windows and Linux.This PR enables under ARM already implemented for ARM64 mechanism updating
g_highest_address
g_lowest_address
via::StompWriteBarrierResize
. Also found that::FlushWriteBarrierInstructionCache
call is needed right such call (at least for ARM).Fixes #17851
Tested manually on Ubuntu/arm for more than 10 hours and Windows/arm for couple hours
@janvorli @jkotas PTAL