This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix version of System.Runtime.Intrinsics.Experimental #19260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there is no servicing version for this package, the 2.1 build was upgrading to an incompatible 4.6 prerelease which caused test build breaks. This package is only needed to build tests. We don't expect to service it for 2.1, given it was an experemental prerelease package. So fix its version at 4.5.0-rtm. Closes #19138.
|
@MattGal PTAL |
GrabYourPitchforks
approved these changes
Aug 2, 2018
MattGal
approved these changes
Aug 2, 2018
tannergooding
approved these changes
Aug 2, 2018
|
arm64 failure looks like infrastructure: |
gbalykov
pushed a commit
to gbalykov/coreclr
that referenced
this pull request
Aug 9, 2018
Since there is no servicing version for this package, the 2.1 build was upgrading to an incompatible 4.6 prerelease which caused test build breaks. This package is only needed to build tests. We don't expect to service it for 2.1, given it was an experemental prerelease package. So fix its version at 4.5.0-rtm. Closes #19138.
zacharycmontoya
pushed a commit
that referenced
this pull request
Aug 9, 2018
* Update PreReleaseLabel to uwp62 * Update dependency paths in dependencies.props * Change the CoreFx dependency to release/2.1 since the build needs CoreFx for the Microsoft.Private.CoreFx.NETCoreApp and Microsoft.NETCore.Platforms. Update dependencies. * Fix version of System.Runtime.Intrinsics.Experimental (#19260) Since there is no servicing version for this package, the 2.1 build was upgrading to an incompatible 4.6 prerelease which caused test build breaks. This package is only needed to build tests. We don't expect to service it for 2.1, given it was an experemental prerelease package. So fix its version at 4.5.0-rtm. Closes #19138.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no servicing version for this package, the 2.1 build was upgrading
to an incompatible 4.6 prerelease which caused test build breaks.
This package is only needed to build tests. We don't expect to service it
for 2.1, given it was an experemental prerelease package.
So fix its version at 4.5.0-rtm.
Closes #19138.