Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Aug 13, 2018

This file is only catalog signed in RS4. Sign during the build. To achieve this copy the CRT binaries locally rather than referencing from the UCRT location directly.

This file is only catalog signed in RS4.  Sign during the build. To achieve this copy the CRT binaries locally rather than referencing from the UCRT location directly.
@mmitche mmitche added area-Infrastructure-coreclr Servicing-consider Issue for next servicing release review labels Aug 13, 2018
@mmitche mmitche changed the title Sign api-ms-win-core-xstate-l2-1-0.dll [release/2.1] Sign api-ms-win-core-xstate-l2-1-0.dll Aug 13, 2018
@mmitche
Copy link
Member Author

mmitche commented Aug 13, 2018

@RussKeldorph PTAL

Copy link

@RussKeldorph RussKeldorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the signing task break the build if this file starts appearing already signed? If not, could we add a check that breaks the build so we know to clean this up?

@mmitche
Copy link
Member Author

mmitche commented Aug 13, 2018

@RussKeldorph Looks like the service will fail in that case.

@mmitche mmitche merged commit f1c9358 into dotnet:release/2.1 Aug 13, 2018
@mmitche mmitche deleted the sign-xstate branch August 13, 2018 20:58
mmitche pushed a commit that referenced this pull request Aug 15, 2018
* Sign api-ms-win-core-xstate-l2-1-0.dll (#19451)

This file is only catalog signed in RS4.  Sign during the build. To achieve this copy the CRT binaries locally rather than referencing from the UCRT location directly.

* Sign xstate binary from correct location (#19470)

* Sign xstate binary from correct location

* Only submit xstate binary for x86
@vivmishra vivmishra added Servicing-Approved-2.1.4 and removed Servicing-consider Issue for next servicing release review labels Aug 16, 2018
@vivmishra
Copy link

Approved for 2.1.4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants