This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Restrict allocation of executable memory by DebuggerHeap #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DebuggerHeap is a common class that is used for both executable and non-executable memory allocations by debugging infrustructure. On Windows, OS supports concept of executable heap and CLR doesn't need to do anything extra for each executable allocation. On Linux/OSX this is not true. That's why this changes preserves fExecutable flag for each heap and makes sure that we mark memory as executable only when it is necessary.
|
LGTM |
|
LGTM as well. This looks like it should ameliorate things until we can get the root cause fixed. Thanks! |
|
LGTM. Thank you! |
There was a problem hiding this comment.
Should this (and the other uses) be under FEATURE_PAL as well?
There was a problem hiding this comment.
It can be, but I don't see a reason to complicate things.
|
LGTM |
Chrisboh
added a commit
that referenced
this pull request
Nov 5, 2015
Restrict allocation of executable memory by DebuggerHeap
|
@Djuffin Is there a plan to bring this in for RC1? |
|
@Chrisboh Yes. rc1 is the real reason we're doing this. |
|
/cc @tzwlai |
This was referenced Nov 5, 2015
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Restrict allocation of executable memory by DebuggerHeap Commit migrated from dotnet/coreclr@1b06b0e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DebuggerHeap is a common class that is used for both executable and
non-executable memory allocations by debugging infrustructure.
On Windows, OS supports concept of executable heap and CLR doesn't need
to do anything extra for each executable allocation. On Linux/OSX
this is not true. That's why this changes preserves fExecutable flag for each heap
and makes sure that we mark memory as executable only when it is necessary.
This change should address performance degradation described in #711.
It doesn't fix managed debugging on CentoOS, but allows to run CoreCLR processes there without constant SELinux warnings.