This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[WIP][release/2.2] Arm stepping fix #19653
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should be automatic 2.1 -> 2.2 integrations, like #19503 . Once your 2.1 change is merged, it should be automatically ported to 2.2. |
|
@jkotas huh, didn't know maestro bot was capable of doing this. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #19255 requested the port of the following PR's from master to 2.1:
#17617
#17879
#17990
#18129
#18247
Porting these fixes from master to 2.2 as well. This addresses gaps in out ARM debugging support and prevent further regressions that would be introduced if #19652 gets merged. In particular, the castings from PISNTR to PCODE were not preserving the thumb bit, causing stepping in ARM debugging to break.