This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port Fix ICU load on OpenSUSE Tumbleweed to 2.1 #19861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, OpenSUSE Tumbleweed has decided to prefix the version number in the SO name of the ICU libraries by "suse". That prevents our ICU version detection code from working. This change adds scanning for SO names that contain that prefix too.
janvorli
added
area-System.Globalization
Servicing-consider
jkotas
approved these changes
Sep 7, 2018
tarekgh
approved these changes
Sep 7, 2018
jamshedd
added
Servicing-approved
|
Approved for 2.1.5 |
|
Was approved |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason, OpenSUSE Tumbleweed has decided to prefix the
version number in the SO name of the ICU libraries by "suse".
That prevents our ICU version detection code from working.
Customer Impact
Customer’s cannot use .NET core on OpenSUSE Tumbleweed unless they disable globalization support.
Regression?
No
Risk
No
Original issue: https://github.com/dotnet/core-setup/issues/4413