Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix perf scenarios in the min_opt config #20010

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Fix perf scenarios in the min_opt config #20010

merged 1 commit into from
Sep 19, 2018

Conversation

kouvel
Copy link

@kouvel kouvel commented Sep 17, 2018 •
edited
Loading

  • The appropriate environment variables were not being set due to a config name mismatch

Fix perf scenarios in the min_opt config
cc2bb7b 
- The appropriate environment variables were not being set due to a name mismatch
@kouvel kouvel added tenet-performance-benchmarks Issue from performance benchmark area-CodeVersioning labels Sep 17, 2018
@kouvel kouvel added this to the 3.0 milestone Sep 17, 2018
@kouvel kouvel self-assigned this Sep 17, 2018
@kouvel kouvel requested review from jorive and noahfalk September 17, 2018 19:22
@kouvel
Copy link
Author

kouvel commented Sep 17, 2018

@dotnet-bot test Windows_NT x64 perf scenarios
@dotnet-bot test Windows_NT x64 min_opts perf scenarios
@dotnet-bot test Windows_NT x86 perf scenarios
@dotnet-bot test Windows_NT x86 min_opts perf scenarios

jorive
jorive approved these changes Sep 17, 2018
View reviewed changes
Copy link

@jorive jorive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kouvel
Copy link
Author

kouvel commented Sep 18, 2018

@dotnet-bot test Ubuntu arm Cross Checked Innerloop Build and Test
test Ubuntu arm Cross Checked no_tiered_compilation_innerloop Build and Test

@kouvel kouvel merged commit 92a0030 into dotnet:master Sep 19, 2018
@kouvel kouvel deleted the PerfMinOptFix branch September 19, 2018 10:30
@kouvel kouvel mentioned this pull request Oct 4, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@noahfalk noahfalk noahfalk approved these changes

@jorive jorive jorive approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kouvel kouvel

Labels

tenet-performance-benchmarks Issue from performance benchmark

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kouvel @noahfalk @jorive