Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

michellemcdaniel
Copy link

No description provided.

@michellemcdaniel
Copy link
Author

@dotnet-bot test ci please

@michellemcdaniel
Copy link
Author

@DrewScoggins PTAL. This fixes the issues we are seeing with https://github.com/dotnet/core-eng/issues/4400

// Set the label.
if (isSmoketest) {
label('Windows.Amd64.ClientRS4.DevEx.15.8.Perf')
python = "C:\\python3.7.0\\python.exe"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, us there a reason why for the smoke tests we use another version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I created the helix queue, that was the latest version (and easiest installer to get). When we reinstall the perfsnakes, we'll likely want to upgrade their python install as well.

@MattGal
Copy link
Member

MattGal commented Oct 16, 2018

I have a simpler fix I'm going to discuss w/ Mariana.

@michellemcdaniel
Copy link
Author

@MattGal Thanks! I've made the change and if it works will close this PR.

@michellemcdaniel
Copy link
Author

@dotnet-bot test this please

@michellemcdaniel
Copy link
Author

I've reopened this issue because we continue to see the python 103 error, despite adding the py.ini file to the machines. It seems to be a sporadic issue that pops up on random machines at random times, with the only fix being to log on to the machines, which is not a good use of our time. So this change is now needed.

@DrewScoggins
Copy link
Member

LGTM

@michellemcdaniel
Copy link
Author

@RussKeldorph I'm I free to ignore the dotnet-coreclr job for now?

@RussKeldorph
Copy link

@adiaaida Yes, we appear to have infra issues with that.

@morganbr @sbomer @hoyosjs

@michellemcdaniel michellemcdaniel merged commit 383f22c into dotnet:master Nov 8, 2018
@sbomer
Copy link
Member

sbomer commented Nov 8, 2018

My apologies - I just disabled it for PRs.

michellemcdaniel added a commit to michellemcdaniel/coreclr that referenced this pull request Nov 28, 2018
* Specify path to python3.5 for perf jobs

* Change path to python in throughput testing
michellemcdaniel added a commit to michellemcdaniel/coreclr that referenced this pull request Nov 28, 2018
* Specify path to python3.5 for perf jobs

* Change path to python in throughput testing
DrewScoggins added a commit that referenced this pull request Nov 29, 2018
Specify path to python3.5 for perf jobs (#20443)
DrewScoggins added a commit that referenced this pull request Nov 29, 2018
Specify path to python3.5 for perf jobs (#20443)
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Specify path to python3.5 for perf jobs

* Change path to python in throughput testing


Commit migrated from dotnet/coreclr@383f22c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants