-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Specify path to python3.5 for perf jobs #20443
Specify path to python3.5 for perf jobs #20443
Conversation
@dotnet-bot test ci please |
@DrewScoggins PTAL. This fixes the issues we are seeing with https://github.com/dotnet/core-eng/issues/4400 |
// Set the label. | ||
if (isSmoketest) { | ||
label('Windows.Amd64.ClientRS4.DevEx.15.8.Perf') | ||
python = "C:\\python3.7.0\\python.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, us there a reason why for the smoke tests we use another version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I created the helix queue, that was the latest version (and easiest installer to get). When we reinstall the perfsnakes, we'll likely want to upgrade their python install as well.
I have a simpler fix I'm going to discuss w/ Mariana. |
@MattGal Thanks! I've made the change and if it works will close this PR. |
@dotnet-bot test this please |
I've reopened this issue because we continue to see the python 103 error, despite adding the py.ini file to the machines. It seems to be a sporadic issue that pops up on random machines at random times, with the only fix being to log on to the machines, which is not a good use of our time. So this change is now needed. |
LGTM |
@RussKeldorph I'm I free to ignore the dotnet-coreclr job for now? |
My apologies - I just disabled it for PRs. |
* Specify path to python3.5 for perf jobs * Change path to python in throughput testing
* Specify path to python3.5 for perf jobs * Change path to python in throughput testing
Specify path to python3.5 for perf jobs (#20443)
Specify path to python3.5 for perf jobs (#20443)
* Specify path to python3.5 for perf jobs * Change path to python in throughput testing Commit migrated from dotnet/coreclr@383f22c
No description provided.