This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Move MemoryFailPoint to shared CoreLib partition #22104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test |
jkotas
reviewed
Jan 21, 2019
src/System.Private.CoreLib/shared/System/Runtime/MemoryFailPoint.cs
Outdated
Show resolved
Hide resolved
|
cc @marek-safar |
filipnavara
force-pushed
the
memoryfailpoint
branch
from
9b2377c to
67eab53
Compare
marek-safar
reviewed
Jan 21, 2019
src/System.Private.CoreLib/shared/System/Runtime/MemoryFailPoint.Windows.cs
Outdated
Show resolved
Hide resolved
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test |
filipnavara
commented
Jan 21, 2019
src/System.Private.CoreLib/src/System/Runtime/MemoryFailPoint.CoreCLR.cs
Outdated
Show resolved
Hide resolved
…e to make sharing with CoreRT easier.
jkotas
reviewed
Jan 21, 2019
src/System.Private.CoreLib/shared/System/Runtime/MemoryFailPoint.Unix.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jan 21, 2019
src/System.Private.CoreLib/shared/System/Runtime/MemoryFailPoint.Windows.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jan 21, 2019
src/System.Private.CoreLib/shared/System/Runtime/MemoryFailPoint.Windows.cs
Outdated
Show resolved
Hide resolved
filipnavara
force-pushed
the
memoryfailpoint
branch
from
a5d0f93 to
0653057
Compare
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test |
jkotas
approved these changes
Jan 22, 2019
|
@marek-safar Looks good to you as well? |
marek-safar
approved these changes
Jan 22, 2019
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Jan 22, 2019
* Move MemoryFailPoint to shared CoreLib partition. * Split MemoryFailPoint into Unix and Windows versions. * Replace MemoryFailPoint.GetMemorySettings FCall with GC.GetSegmentSize to make sharing with CoreRT easier. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Jan 22, 2019
* Move MemoryFailPoint to shared CoreLib partition. * Split MemoryFailPoint into Unix and Windows versions. * Replace MemoryFailPoint.GetMemorySettings FCall with GC.GetSegmentSize to make sharing with CoreRT easier. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
|
Thanks for reviews! |
marek-safar
pushed a commit
to mono/mono
that referenced
this pull request
Jan 22, 2019
* Move MemoryFailPoint to shared CoreLib partition. * Split MemoryFailPoint into Unix and Windows versions. * Replace MemoryFailPoint.GetMemorySettings FCall with GC.GetSegmentSize to make sharing with CoreRT easier. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
|
@filipnavara Thank you for all your work on all this. |
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Jan 22, 2019
* Move MemoryFailPoint to shared CoreLib partition. * Split MemoryFailPoint into Unix and Windows versions. * Replace MemoryFailPoint.GetMemorySettings FCall with GC.GetSegmentSize to make sharing with CoreRT easier. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 22, 2019
* Move MemoryFailPoint to shared CoreLib partition. * Split MemoryFailPoint into Unix and Windows versions. * Replace MemoryFailPoint.GetMemorySettings FCall with GC.GetSegmentSize to make sharing with CoreRT easier. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Jan 22, 2019
* Move MemoryFailPoint to shared CoreLib partition. * Split MemoryFailPoint into Unix and Windows versions. * Replace MemoryFailPoint.GetMemorySettings FCall with GC.GetSegmentSize to make sharing with CoreRT easier. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Move MemoryFailPoint to shared CoreLib partition. * Split MemoryFailPoint into Unix and Windows versions. * Replace MemoryFailPoint.GetMemorySettings FCall with GC.GetSegmentSize to make sharing with CoreRT easier. Commit migrated from dotnet/coreclr@635a609
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #17904 and #21932.