Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Reduce the number of Linux arm32 periodic jobs triggered #24105

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Reduce the number of Linux arm32 periodic jobs triggered #24105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 31 additions & 5 deletions netci.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,8 +1267,14 @@ def static addNonPRTriggers(def job, def branch, def isPR, def architecture, def
// Check scenario.
switch (scenario) {
case 'crossgen_comparison':
if (isFlowJob && ((os == 'Ubuntu' && architecture == 'arm') || (os == 'Ubuntu16.04' && architecture == 'arm64')) && (configuration == 'Checked' || configuration == 'Release')) {
addPeriodicTriggerHelper(job, '@daily')
if (isFlowJob && (configuration == 'Checked' || configuration == 'Release')) {
if (os == 'Ubuntu' && architecture == 'arm') {
// Not enough Linux/arm32 hardware for this.
// addPeriodicTriggerHelper(job, '@daily')
}
if (os == 'Ubuntu16.04' && architecture == 'arm64') {
addPeriodicTriggerHelper(job, '@daily')
}
}
break

Expand Down Expand Up @@ -1316,7 +1322,9 @@ def static addNonPRTriggers(def job, def branch, def isPR, def architecture, def
if (isFlowJob) {
// Currently no push triggers, with limited arm Linux hardware.
// TODO: If we have enough machine capacity, add some arm Linux push triggers.
addPeriodicTriggerHelper(job, '@daily')

// Duplicated by AzDO
// addPeriodicTriggerHelper(job, '@daily')
}
}
break
Expand Down Expand Up @@ -1353,7 +1361,10 @@ def static addNonPRTriggers(def job, def branch, def isPR, def architecture, def
// arm r2r jobs should only run weekly.
else if (architecture == 'arm') {
if (isFlowJob) {
addPeriodicTriggerHelper(job, '@weekly')
// Linux arm32 done in AzDO
if (os == 'Windows_NT') {
addPeriodicTriggerHelper(job, '@weekly')
}
}
}
// arm64 r2r jobs should only run weekly.
Expand Down Expand Up @@ -1402,7 +1413,10 @@ def static addNonPRTriggers(def job, def branch, def isPR, def architecture, def
}
else if (architecture == 'arm') {
if (isFlowJob) {
addPeriodicTriggerHelper(job, '@weekly')
// Linux arm32 duplicated by AzDO
if (os == 'Windows_NT') {
addPeriodicTriggerHelper(job, '@weekly')
}
}
}
else if (architecture == 'arm64') {
Expand Down Expand Up @@ -1512,6 +1526,10 @@ def static addNonPRTriggers(def job, def branch, def isPR, def architecture, def
if (os in bidailyCrossList) {
break
}
if ((os == 'Ubuntu') && (architecture == 'arm') && !isCoreFxScenario(scenario)) {
// Linux arm32 duplicated by AzDO
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not all of them are duplicated by AzDO but I think we do not care because they will disappear soon anyway (zapdisable or 'tailcallstress' for example).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By "disappear soon", I hope you mean, "will appear soon in AzDO runs"?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not aware if such work item exists somewhere, do we have a GitHub issue to track that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. Is AzDO work (such as creating the full set of jobs that Jenkins previously ran) tracked in GitHub?

break
}
// ARM corefx testing uses non-flow jobs to provide the configuration-specific
// build for the flow job. We don't need cron jobs for these. Note that the
// Windows ARM jobs depend on a Windows "build only" job that exits the trigger
Expand Down Expand Up @@ -1546,6 +1564,10 @@ def static addNonPRTriggers(def job, def branch, def isPR, def architecture, def
if (os in bidailyCrossList) {
break
}
if ((os == 'Ubuntu') && (architecture == 'arm')) {
// Linux arm32 duplicated by AzDO
break
}
addPeriodicTriggerHelper(job, '@weekly')
break
case 'gcstress0xc':
Expand All @@ -1565,6 +1587,10 @@ def static addNonPRTriggers(def job, def branch, def isPR, def architecture, def
if (os in bidailyCrossList) {
break
}
if ((os == 'Ubuntu') && (architecture == 'arm')) {
// Linux arm32 duplicated by AzDO
break
}
addPeriodicTriggerHelper(job, '@weekly')
break

Expand Down