This repository was archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove create assembly name #24154
Merged
Merged
Remove create assembly name #24154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #24135 CreateAssemblyName was not compatible with AssemblyLoadContext isolation. Assembly.Load(string) Assembly.LoadWithPartialName(string) Activator.CreateInstance(...)
sdmaclea
added a commit
to sdmaclea/corefx
that referenced
this pull request
Apr 21, 2019
dotnet/coreclr#24154 will remove the quirk the CreateInstanceAssemblyResolve test was testing. It will now throw a FileNotFoundException, without triggering a resolving event.
sdmaclea
added a commit
to sdmaclea/corefx
that referenced
this pull request
Apr 21, 2019
dotnet/coreclr#24154 will remove the quirk the CreateInstanceAssemblyResolve test was testing. It will now throw a FileNotFoundException, without triggering a resolving event.
sdmaclea
added a commit
to sdmaclea/corefx
that referenced
this pull request
Apr 21, 2019
dotnet/coreclr#24154 will remove the quirk the CreateInstanceAssemblyResolve test was testing. It will now throw a FileNotFoundException, without triggering a resolving event.
jkotas
pushed a commit
to dotnet/corefx
that referenced
this pull request
Apr 22, 2019
dotnet/coreclr#24154 will remove the quirk the CreateInstanceAssemblyResolve test was testing. It will now throw a FileNotFoundException, without triggering a resolving event.
jkotas
approved these changes
Apr 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Apr 22, 2019
* Remove RuntimeAssembly.CreateAssemblyName Fixes #24135 CreateAssemblyName was not compatible with AssemblyLoadContext isolation. Assembly.Load(string) Assembly.LoadWithPartialName(string) Activator.CreateInstance(...) * Remove unused AssemblyNameNative::Init arguments * Temp disable corefx CreateInstanceAssemblyResolve Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Apr 22, 2019
* Remove RuntimeAssembly.CreateAssemblyName Fixes #24135 CreateAssemblyName was not compatible with AssemblyLoadContext isolation. Assembly.Load(string) Assembly.LoadWithPartialName(string) Activator.CreateInstance(...) * Remove unused AssemblyNameNative::Init arguments * Temp disable corefx CreateInstanceAssemblyResolve Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Apr 22, 2019
* Remove RuntimeAssembly.CreateAssemblyName Fixes #24135 CreateAssemblyName was not compatible with AssemblyLoadContext isolation. Assembly.Load(string) Assembly.LoadWithPartialName(string) Activator.CreateInstance(...) * Remove unused AssemblyNameNative::Init arguments * Temp disable corefx CreateInstanceAssemblyResolve Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Remove RuntimeAssembly.CreateAssemblyName Fixes dotnet/coreclr#24135 CreateAssemblyName was not compatible with AssemblyLoadContext isolation. Assembly.Load(string) Assembly.LoadWithPartialName(string) Activator.CreateInstance(...) * Remove unused AssemblyNameNative::Init arguments * Temp disable corefx CreateInstanceAssemblyResolve Commit migrated from dotnet/coreclr@479d7ed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.