Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

sdmaclea
Copy link

No description provided.

Fixes #24135

CreateAssemblyName was not compatible with AssemblyLoadContext isolation.

Assembly.Load(string)
Assembly.LoadWithPartialName(string)
Activator.CreateInstance(...)
@sdmaclea sdmaclea added this to the 3.0 milestone Apr 21, 2019
@sdmaclea sdmaclea requested a review from jkotas April 21, 2019 22:47
@sdmaclea sdmaclea self-assigned this Apr 21, 2019
sdmaclea added a commit to sdmaclea/corefx that referenced this pull request Apr 21, 2019
dotnet/coreclr#24154 will remove the quirk the CreateInstanceAssemblyResolve
test was testing. It will now throw a FileNotFoundException, without triggering
a resolving event.
sdmaclea added a commit to sdmaclea/corefx that referenced this pull request Apr 21, 2019
dotnet/coreclr#24154 will remove the quirk the CreateInstanceAssemblyResolve
test was testing. It will now throw a FileNotFoundException, without triggering
a resolving event.
sdmaclea added a commit to sdmaclea/corefx that referenced this pull request Apr 21, 2019
dotnet/coreclr#24154 will remove the quirk the CreateInstanceAssemblyResolve
test was testing. It will now throw a FileNotFoundException, without triggering
a resolving event.
jkotas pushed a commit to dotnet/corefx that referenced this pull request Apr 22, 2019
dotnet/coreclr#24154 will remove the quirk the CreateInstanceAssemblyResolve
test was testing. It will now throw a FileNotFoundException, without triggering
a resolving event.
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 479d7ed into dotnet:master Apr 22, 2019
@sdmaclea sdmaclea deleted the RemoveCreateAssemblyName branch April 22, 2019 15:50
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Apr 22, 2019
* Remove RuntimeAssembly.CreateAssemblyName

Fixes #24135

CreateAssemblyName was not compatible with AssemblyLoadContext isolation.

Assembly.Load(string)
Assembly.LoadWithPartialName(string)
Activator.CreateInstance(...)

* Remove unused AssemblyNameNative::Init arguments

* Temp disable corefx CreateInstanceAssemblyResolve

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this pull request Apr 22, 2019
* Remove RuntimeAssembly.CreateAssemblyName

Fixes #24135

CreateAssemblyName was not compatible with AssemblyLoadContext isolation.

Assembly.Load(string)
Assembly.LoadWithPartialName(string)
Activator.CreateInstance(...)

* Remove unused AssemblyNameNative::Init arguments

* Temp disable corefx CreateInstanceAssemblyResolve

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corert that referenced this pull request Apr 22, 2019
* Remove RuntimeAssembly.CreateAssemblyName

Fixes #24135

CreateAssemblyName was not compatible with AssemblyLoadContext isolation.

Assembly.Load(string)
Assembly.LoadWithPartialName(string)
Activator.CreateInstance(...)

* Remove unused AssemblyNameNative::Init arguments

* Temp disable corefx CreateInstanceAssemblyResolve

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Remove RuntimeAssembly.CreateAssemblyName

Fixes dotnet/coreclr#24135

CreateAssemblyName was not compatible with AssemblyLoadContext isolation.

Assembly.Load(string)
Assembly.LoadWithPartialName(string)
Activator.CreateInstance(...)

* Remove unused AssemblyNameNative::Init arguments

* Temp disable corefx CreateInstanceAssemblyResolve


Commit migrated from dotnet/coreclr@479d7ed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants