This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Handle more configs in GCToEEInterface #25653
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds handling for the following configs: * "GCNoAffinitize" (from "System.GC.NoAffinitize") * "GCHeapAffinitizeMask" (from "System.GC.HeapAffinitizeMask") * "GCHeapCount" (from "System.GC.HeapCount") These configs were already handled correctly in EEConfig::sync, so that does not need to be changed. Just the access from GC needs to be fixed. Previously the configs were correctly read, but GC did not see those values. Verified this change by debugging into GCToEEInterface::GetBooleanConfigValue and GCToEEInterface::GetIntConfigValue as well as their uses in SVR::GCHeap::Initialize.
ghost
requested a review
from 
ghost
mentioned this pull request
|
I don't think that this make .NET Core 3.0 bar. Thanks. |
|
This PR should be subsumed by #25469 |
ghost
closed this
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds handling for the following configs:
These configs were already handled correctly in EEConfig::sync, so that
does not need to be changed. Just the access from GC needs to be fixed.
Previously the configs were correctly read,
but GC did not see those values.
Verified this change by debugging into
GCToEEInterface::GetBooleanConfigValue and
GCToEEInterface::GetIntConfigValue as well as their uses in
SVR::GCHeap::Initialize.