Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upModify the windows amd64 unwinder to work as jitted code unwinder on Uni... #259
Conversation
dnfclas
added
the
cla-not-required
label
Feb 13, 2015
This comment has been minimized.
This comment has been minimized.
|
Represents part of #177 |
janvorli
referenced this pull request
Feb 13, 2015
Closed
Implement stack unwinding and exceptions for Linux #177
This comment has been minimized.
This comment has been minimized.
|
LGTM |
added a commit
that referenced
this pull request
Feb 13, 2015
janvorli
merged commit 0e20a9e
into
dotnet:master
Feb 13, 2015
1 check passed
default
Merged build finished.
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
janvorli commentedFeb 13, 2015
Update the windows amd64 unwinder from its source to the latest version
and add context pointers updating that was excluded before.
Change methods of the OOPStackUnwinder and OOPStackUnwinderAMD64 to be
static, since the base class has no data members and the unwinding is
always using the processor specific subclass.
Modify the code so that it is built in two flavors. The first one
is the DAC flavor which is used by the debugger. The second one will be
used for jitted code stack frames unwinding on non-Windows systems.