This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Respect profiler provided IL maps in the DAC (Port #25802 to 3.1) #27075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entedCodeMap (dotnet#25802) * Fix GetSequencePoints when profiler provides mapping via SetILInstrumentedCodeMap * code review feedback
|
Approved for 3.1. Please check with WillGobde before merge. It seems that release branch is in freeze-mode right now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description:
When we implemented tiered compilation in 2.1 there was a typo that made it so we would ignore any profiler provided IL maps. This means that if a profiler modifies a function debugging is broken.
Bug Impact:
This was found because a profiler vendor who maintains a unit testing framework specifically needs this functionality and not having it blocks their product from running on coreclr.
PR Risks:
None