[release/3.1] Fix minidumps not loading in VS issue #27553
Conversation
Fix a function that was ifdef'ed needed for the metadata locator callbacks to work. Fix some not properly DAC'ized code in the type desc and server GC code. Caused an exception during dump generation. Issue: https://github.com/dotnet/coreclr/issues/26907
|
Issue Customer impact Fix description To fix this end-to-end it requires a change in VS to understand R2R images and not treat them like NGEN ones. Risk |
|
Please mail .net core tactics alias when this is ready for consideration. |
danmoseley
changed the title
| DacEnumMemoryRegion(dac_cast<TADDR>(pHeap->finalize_queue), sizeof(dac_finalize_queue)); | ||
| DacEnumMemoryRegion(dac_cast<TADDR>(pHeap->generation_table), gen_table_size); | ||
|
|
||
| TADDR taddrTable = dac_cast<TADDR>(pHeap) + offsetof(dac_gc_heap, generation_table); |
There was a problem hiding this comment.
What is different about the new line vs. the old one? If they compute different values does that mean the same issue exists in the DacEnumMemoryRegion(pHeap->finalize_queue) call that preceeds this?
There was a problem hiding this comment.
The original code was throwing an invalid memory exception because generation_table is an array and the dac_cast macro didn't seem to handle it correctly.
|
@mikem8361 was this supposed to be merged? I didn't get the impression that tactics had signed off on it yet. |
|
I did get approval from tactics. |
|
Cool, sorry to add noise : ) |
3 participants
Fix a function that was ifdef'ed needed for the metadata locator callbacks to work.
Fix some not properly DAC'ized code in the type desc and server GC code. Caused an exception during dump generation.
Issue: https://github.com/dotnet/coreclr/issues/26907