Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

dotnet-maestro-bot
Copy link

I detected changes in the release/3.0 branch which have not been merged yet to release/3.1. I'm a robot and am configured to help you automatically keep release/3.1 up to date, so I've opened this PR.

This PR merges commits made on release/3.0 by the following committers:

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout release/3.0
git pull --ff-only
git checkout release/3.1
git pull --ff-only
git merge --no-ff release/3.0

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet-maestro-bot/coreclr HEAD:merge/release/3.0-to-release/3.1
or if you are using SSH
git push git@github.com:dotnet-maestro-bot/coreclr HEAD:merge/release/3.0-to-release/3.1

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/3.0-to-release/3.1'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/release/3.0-to-release/3.1 release/3.1
git pull https://github.com/dotnet-maestro-bot/coreclr merge/release/3.0-to-release/3.1
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet-maestro-bot/coreclr HEAD:merge/release/3.0-to-release/3.1
or if you are using SSH
git checkout -b merge/release/3.0-to-release/3.1 release/3.1
git pull git@github.com:dotnet-maestro-bot/coreclr merge/release/3.0-to-release/3.1
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet-maestro-bot/coreclr HEAD:merge/release/3.0-to-release/3.1

Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

brianrob and others added 8 commits October 15, 2019 11:23
* update branding

* remove stable properties from coreclr as it never stablises
dotnet#27820)

* Add fix for restore of ilasm

The restore logic in buildtools tried to use a netcoreapp2.1 TFM for Linux-musl.
This ended up restoring Linux-x64 binaries which then broke the test build.
This change works around this by saving a copy of the depproj that BuildTools used into
the tree and restore it as a 3.0 app manually in init-tools on our side of the build.

* Change to a 3.0 SDK for servicing

* Bump test versions of ilasm and runtime package to match the RC
* Update dependencies from https://github.com/dotnet/core-setup build 20191016.12

- Microsoft.NETCore.App - 3.0.1-servicing-19516-12

* Update dependencies from https://github.com/dotnet/core-setup build 20191121.02

- Microsoft.NETCore.App - 3.0.2-servicing-19571-02
@mmitche
Copy link
Member

mmitche commented Nov 27, 2019

@wtgodbe @Anipik Without this, the branding isn't properly updated in coreclr. It appears the branding string is in both Versions.props as well as dir.common.props. Can this be fixed?

@mmitche mmitche requested review from elinor-fung and Anipik and removed request for elinor-fung November 27, 2019 16:39
@mmitche
Copy link
Member

mmitche commented Nov 27, 2019

@Anipik can you look at these failures?

@Anipik
Copy link

Anipik commented Nov 27, 2019

the issue is same as was in this #27921
@jashook is anybody looking into it ?

@jashook
Copy link

jashook commented Nov 27, 2019

Yes #27952

@Anipik
Copy link

Anipik commented Nov 27, 2019

Okay thanks.

@mmitche
Copy link
Member

mmitche commented Dec 2, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mmitche mmitche merged commit 53826ca into dotnet:release/3.1 Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants