Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port of dotnet/runtime#1059 to 3.1 branch #27986

Open
wants to merge 1 commit into
base: release/3.1
from

Conversation

@CarolEidt
Copy link
Member

CarolEidt commented Jan 10, 2020

This is the fix for #27924. This is a GC hole bug that was found externally, #27590.
The cause is that the JIT was using the target type of the subtract when it needed
to make a copy of the source, but it needs to use the source type.

Customer Impact

Corruption of state that is non-deterministic and hard to track down.

Regression?

Not a recent regression, but exposed by Unsafe.ByteOffset.

Testing

The fix has been verified in the runtime repo.

Risk

Low: The fix is straightfoward and only impacts 3 lines of code.

Code Reviewer

@jaschook and @jkotas

This is the fix for #27924. This is a GC hole bug that was found externally, #27590.
The cause is that the JIT was using the target type of the subtract when it needed
to make a copy of the source, but it needs to use the source type.

## Customer Impact
Corruption of state that is non-deterministic and hard to track down.

## Regression?
Not a recent regression, but exposed by Unsafe.ByteOffset.

## Testing
The fix has been verified in the runtime repo.

## Risk
Low: The fix is straightfoward and only impacts 3 lines of code.
@wtgodbe

This comment has been minimized.

Copy link
Member

wtgodbe commented Jan 17, 2020

Is this for 3.1.3? CC @jeffschwMSFT

@MeiChin-Tsai

This comment has been minimized.

Copy link

MeiChin-Tsai commented Jan 17, 2020

It has to be 3.1.3. Miss the 3.1.2 window already.

@MeiChin-Tsai

This comment has been minimized.

Copy link

MeiChin-Tsai commented Jan 17, 2020

Please add code reviewer.

@CarolEidt

This comment has been minimized.

Copy link
Member Author

CarolEidt commented Jan 17, 2020

Please add code reviewer.

Added above

@CarolEidt CarolEidt requested review from jkotas and jashook Jan 17, 2020
@jeffschwMSFT jeffschwMSFT added this to the 3.1.x milestone Jan 17, 2020
@jkotas
jkotas approved these changes Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.