This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port the 5.0 fix for issue #1104 #28003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pull Request Runtime\#1734 - This change corrects a cut-and paste typo with a previous commit. - Includes test case Runtime_1104.cs
sandreenko
approved these changes
Jan 25, 2020
|
@BruceForstall PTAL |
|
fyi, fix in master: dotnet/runtime#1734 |
BruceForstall
approved these changes
Jan 28, 2020
jeffschwMSFT
added
area-CodeGen
Servicing-consider
|
Approved for .NET Runtime, we will now seek approval for the next release |
jeffschwMSFT
added
Servicing-approved
|
Approved for 3.1.3 (March) - need to wait for the branch to open before merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for the 3.1 branch for the runtime issue #1104
This a a bug which Sergey Andreenko @sandreenko found where the JIT can
optimize away a range check, allowing an out of bounds read or write.
The original cause was from PR #23109, where a cut-and-paste typo inverted the
initialization code for
bool alreadyPresentinRangeCheck::IsMonotonicallyIncreasingCustomer Impact
Invalid code gen that allows an out of bounds read or write.
Regression?
A regression introduced during 3.0 development.
Testing
The fix has been verified in the runtime repo.
Risk
Low: The fix is straightforward and only impacts 1 line of code.
Code Reviewer
@sandreenko and @BruceForstall