This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Backport Cross DAC runtime layout changes #28035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This represents the minimum set of changes required to be able to build the Cross DAC out of band. This fixes the layout difference between the Windows compiler and the clang Linux compiler.
|
I believe this represents the complete set of changes to the runtime so that the cross OS DAC layout would match the runtime for all architectures. It is marked draft because:
Editted |
hoyosjs
approved these changes
Apr 22, 2020
jeffschwMSFT
added
the
Servicing-consider
sdmaclea
force-pushed
the
DacRuntimeLayout
branch
from
f99ab57 to
07fde27
Compare
sdmaclea
force-pushed
the
DacRuntimeLayout
branch
from
07fde27 to
501d025
Compare
jeffschwMSFT
added
Servicing-approved
|
Approved for June (via tactics) |
sdmaclea
added a commit
that referenced
this pull request
Jul 16, 2020
PR #28035 changed the layout rules for two types. Adjust the verification to match new code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This represents the minimum set of changes required to
be able to build the Cross DAC out of band.
This fixes the layout difference between the Windows
compiler and the clang Linux compiler.
The code adds
alignasdirectives to allow cross OS compilation type layouts to match.Also moves a bool into a bitfield.
Customer impact
This allows us to develop and test a new 3.1 feature (#28027) allowing triage of Linux dumps on Windows.
Regression?
No, this is in support of a new 3.1 feature.
Testing
This has been tested by using a PDB to Dwarf comparison tool to check type layouts.
This is based on a PR which has been in the 5.0 branch for a ~6 weeks.
Risk
Low