This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix DataTargetReader::AlignBase() #28072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAC_ALIGNAS macro was used to force MSVC and clang/gcc compilers layouts to match. Update DataTargetReader::AlignBase() assumptions based on new layouts
sdmaclea
added
area-Diagnostics
Servicing-consider
hoyosjs
approved these changes
Jul 31, 2020
leecow
added
Servicing-approved
sdmaclea
added a commit
to sdmaclea/coreclr
that referenced
this pull request
Aug 12, 2020
DAC_ALIGNAS macro was used to force MSVC and clang/gcc compilers layouts to match. Update DataTargetReader::AlignBase() assumptions based on new layouts
sdmaclea
added a commit
that referenced
this pull request
Aug 12, 2020
DAC_ALIGNAS macro was used to force MSVC and clang/gcc compilers layouts to match. Update DataTargetReader::AlignBase() assumptions based on new layouts
sdmaclea
added a commit
to sdmaclea/coreclr
that referenced
this pull request
Aug 12, 2020
DAC_ALIGNAS macro was used to force MSVC and clang/gcc compilers layouts to match. Update DataTargetReader::AlignBase() assumptions based on new layouts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#28033 added
DAC_ALIGNASmacro to force MSVC and clang/gcc compilers layouts to match. UnfortunatelyDataTargetReader::AlignBase()hard coded the difference in layouts. This PR updatesDataTargetReader::AlignBase()to remove the obsolete assumption.Customer impact
Customer reported being unable to examine stack traces using the out of process stack unwinder. This breaks their diagnostic tools.
Regression
Yes: Introduced by #28033
The regression was missed because the regression was only for Linux targets and
FEATURE_METADATA_VERIFY_LAYOUTSis disabled on Linux.Testing
Enabled
FEATURE_METADATA_VERIFY_LAYOUTSin draft PR #28063 to verify layout assumptions on Linux too. Not in this PR simply to reduce size of PR to more easily meet servicing BAR.Also tested with a custom built version of .NET Core 3.1.5 with this patch and the originals customers reported issue.
Risk
Low code is only used in DBI for debugging.