This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Fix FC_NO_TAILCALL with newer compilers #28132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C11 standard treats trivial infinite loops as undefined behavior and allows compilers to optimize them out completely. Add "volatile" on FC_NO_TAILCALL to defeat this optimization
jeffschwMSFT
approved these changes
Feb 9, 2021
leecow
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #dotnet/runtime#45999 to release/3.1
Customer Impact
Once we move to the new MSVC toolset, we will see intermittent runtime crashes during GC without this fix.
The new MSVC toolset performs more optimizations that violate invariants in the low-level runtime code. This change is suppressing the optimization in a specific situation.
Testing
The fix was tested and merged in master. This is a port of the fix.
Risk
Master branch had this fix for some time now. Based on that the risk is low.