This repository was archived by the owner on Jan 23, 2023. It is now read-only.
GCStress eventing fix #28148
Merged
GCStress eventing fix #28148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sywhang
approved these changes
Feb 17, 2021
jeffschwMSFT
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Feb 17, 2021
josalem
approved these changes
Feb 17, 2021
leecow
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #26776 to 3.1.
EventPipe had an issue where it would see a reentrant stackwalk during GCStress, which triggers asserts on checked or debug builds.
Customer Impact
Having tests fail under GCStress means we are less confident when preparing fixes for 3.1. We could alternatively disable these tests under GCStress, but that would mean less testing when doing GCStress runs.
Testing
This fix was in master for effectively all of the 5.0 release, and I verified that it fixes the failing eventing tests by running the tests manually.
Risk
The risk is low, this fix shipped in 5.0.