Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Nov 18, 2021

No description provided.

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Juan!

@hoyosjs hoyosjs changed the title Change CI to also use macOS-latest to prevent differences in CI and Official build [release/3.1] Change CI to also use macOS-latest to prevent differences in CI and Official build Nov 18, 2021
@hoyosjs
Copy link
Member Author

hoyosjs commented Nov 18, 2021

This one fails because of the issue #28220 is trying to address.

@jeffschwMSFT
Copy link
Member

@safern is it safe to merge these now?

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This is an infra change and we should treat as tell mode.

@safern
Copy link
Member

safern commented Nov 18, 2021

Branch is closed till December 17th after the branding changes are made. Will mark as no merge, thanks for asking!

@safern safern added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 18, 2021
@safern safern removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 3, 2022
@safern safern merged commit a4faec0 into release/3.1 Jan 3, 2022
@safern safern deleted the juhoyosa/change-macos-pool branch January 3, 2022 04:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants