This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Backport AVX context fix #28238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why so many whitespace changes? Is that just auto-format after pasting code or these are real old/new diffs? |
|
Auto-whitespace changes, I think. If it's removing whitespace at the end of lines, VS code did it. |
|
I will take a look at the failures |
|
I have re-done porting manually. |
|
@jkotas Could you take a look? |
|
@agocke needs the servicing label. |
leecow
added
Servicing-approved
jeffschwMSFT
approved these changes
Apr 14, 2022
|
WooHoo!!! I can close dotnet/runtime#65292 now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of dotnet/runtime#66356
Port of a fix for dotnet/runtime#65292 and issues found along the way related to AVX registers and EE suspension.
Customer Impact
It is relatively easy to end up running AVX-accelerated code nowdays. Copying or comparing arrays or spans, using buffered IO are just some examples.
Issues with storing/restoring AVX context during EE suspension could result in:
Testing
Regular test passes.
Risk
Medium.
The code involved is fairly old. We keep discovering assumptions that may no longer hold. We have seen cases where fixing one bug exposes another. To our knowledge these fixes are robust, but this is a delicate area.