This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Reset current_no_gc_region_info after leaving no gc region implicitly #28265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffschwMSFT
added
area-GC
Servicing-consider
mangod9
approved these changes
Aug 11, 2022
cshung
changed the title
carlossanlop
added
Servicing-approved
|
Approved via email by Tactics. |
hoyosjs
added a commit
that referenced
this pull request
Sep 15, 2022
* Update branding to 3.1.29 (#28260) * Reset current_no_gc_region_info after leaving no gc region implicitly (#28265) * Updated finalize-publish.yml Co-authored-by: vseanreesermsft <78103370+vseanreesermsft@users.noreply.github.com> Co-authored-by: dotnet-bot <dotnet-bot@microsoft.com> Co-authored-by: Sean Reeser <v-seanreeser@microsoft.com> Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Co-authored-by: Andrew Au <cshung@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport dotnet/runtime#73602.
Customer Impact
Customers reported occasional
System.InvalidOperationExceptionwith messageThe NoGCRegion mode was already in progresswhen callingGC.TryStartNoGCRegion. This is preventing them from using this optimization and impacting their cold start latencies.Testing
Customers have tried the fix on .NET 6 overnight and reported the exception never appears again. Meanwhile, there is an unpatched machine and observed 72 exceptions of the same type in the same time interval, proving this does fix the bug.
Risk
Low. This only impact customer using
TryStartNoGCRegion, and this is the right thing to do.