Fix for CoreCLR issue 3049

[gkhanna79]

No description provided.

[gkhanna79]

@dotnet-bot test this please

[gkhanna79]

@jkotas PTAL.

[gkhanna79]

Fixes https://github.com/dotnet/coreclr/issues/3049

[AndyAyersMS]

Not part of your change, but related... Why do we link with /LTCG (in release modes) if we never compile with /GL?

[jkotas]

https://github.com/dotnet/coreclr/blob/master/CMakeLists.txt#L426 is passing /GL for release modes. I have done a quick check and I see it passed in to cl in the .rsp file. Do you see it not getting passed it to the compiler in some cases?

[AndyAyersMS]

Sorry for the false alarm, I was confused. I was just randomly looking through the file and didn't see the /GL.

[AndyAyersMS]

@gkhanna79 I'm still seeing frequent linker crashes. Not a blocker since I can just rebuild, but annoying. Happens when I'm doing development and so am always incrementally rebuilding stuff.

@dotnet/jit-contrib anybody else running into this?

[jashook]

I see link errors for the arm64 cross build only on certain machines. Unknown if it is related.

[gkhanna79]

CFG is not enabled for Arm64

[LLITCHEV]

I used to see this every other time for Debug builds for Windows. Fr some reason the installation of My VS got corrupted yesterday (the mspdb14.dll) was failing version check, so I reinstalled VS last night. This morning I have seen the crash only twice.

[pgavlin]

I've also run into this, specifically when incrementally linking crossgen.exe.

[BruceForstall]

I hit it almost every build. Succeeds on rebuild.

[gkhanna79]

Do you see this on debug or release build? Also, does the failing build command line having incremental linking disabled (which is what this change enabled)?

[BruceForstall]

I mostly do plain vanilla debug x64 builds. Don't know what flags are used.