This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Preserve value numbers when morphing multiplication into shift. #3067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@briansull PTAL |
|
@dotnet-bot test Windows_NT jitstress1 |
|
@dotnet-bot test Windows_NT jitstress2 |
| void GenTree::SetOper(genTreeOps oper) | ||
| void GenTree::SetOper(genTreeOps oper, bool clearVN) | ||
| { | ||
| gtOper = oper; |
There was a problem hiding this comment.
I don't think we have tried building the JIT without SMALL_TREE_NODES defined in quite sometime.
But you should go ahead and add the if (clearVM) logic here as well as it appears to just be missing.
The instance field gtVNPair is available with and without SMALL_TREE_NODES.
|
@briansull I addressed your feedback, PTAL. |
This change fixes a morpher transformation of multiplication to shift to preserve the value number of the tree since the new shift expression will compute the same value as the old multiplication expression. Without that change we were getting asserts in fgMoveOpsLeft, which expects to see value numbers on trees it transforms. Closes #2920.
erozenfeld
force-pushed
the
MultToShiftVN
branch
from
44dfacc to
96a998d
Compare
|
@dotnet-bot retest |
|
@dotnet-bot test Windows_NT jitstress1 |
|
@dotnet-bot test Windows_NT jitstress2 |
|
LGTM |
1 similar comment
|
LGTM |
erozenfeld
added a commit
that referenced
this pull request
Feb 8, 2016
Preserve value numbers when morphing multiplication into shift.
erozenfeld
added a commit
to erozenfeld/coreclr
that referenced
this pull request
Feb 10, 2016
The code to change multiplication to shift shouldn't be under LEA_AVAILABLE since the code to process multiplication by power of 2 isn't.
erozenfeld
added a commit
that referenced
this pull request
Feb 11, 2016
Small correction for #3067.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a morpher transformation of multiplication to shift
to preserve the value number of the tree since the new shift expression
will compute the same value as the old multiplication expression.
Without that change we were getting asserts in fgMoveOpsLeft,
which expects to see value numbers on trees it transforms.
Closes #2920.