This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix issue with excessive memory use by debug and checked jits #3203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In dotnet#3051 the jit started calling `eeGetClassFullName` for both caller and callee handles even when dumping was disabled, passed this information to the logging messages where previously the caller and callee were identified via other context, and prepared the full name dump artifacts for all inline decisions rather than the selective cases handled previously. This change caused excessive memory use in some tests. This change makes the calls to `eeGetClassFullName` conditional on whether dumping is enabled, and does not require these calls for logging messages.
AndyAyersMS
force-pushed
the
FixJitMemoryUsage
branch
from
5ec6877 to
5e85230
Compare
|
@BruceForstall PTAL. This fixes the issues you reported to me privately. Note this interacts with #3196. I'll get this in first and then propagate the change there. |
|
👍 LGTM |
AndyAyersMS
added a commit
that referenced
this pull request
Feb 17, 2016
Fix issue with excessive memory use by debug and checked jits
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3051 the jit started calling
eeGetClassFullNamefor both caller and callee handleseven when dumping was disabled, passed this information to
the logging messages where previously the caller and callee were
identified via other context, and prepared the full name dump artifacts
for all inline decisions rather than the selective cases handled
previously.
This change caused excessive memory use in some tests.
This change makes the calls to
eeGetClassFullNameconditional onwhether dumping is enabled, and does not require these calls for logging
messages.