This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix generic struct delegate in ReadyToRun (#3690) #3911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port commit 70aee6c from master branch to release/1.0.0-rc2 branch The following code pattern triggers a crash when compiled into Ready To Run: struct S<T> { public void M() { ... } } class C { } Then create a delegate using S<C>.M The cause of the crash is calling S<C>.M normally reaches a shared generic method S<__Canon>.M, but for delegate creation we need to use the actual S<C>.M. Ready To Run generated code that attempts to create delegate using S<__Canon>.M, which is not allowed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port commit 70aee6c from master branch to release/1.0.0-rc2 branch
The following code pattern triggers a crash when compiled into Ready To Run:
The cause of the crash is calling S.M normally reaches a shared generic
method S<__Canon>.M, but for delegate creation we need to use the actual
S.M. Ready To Run generated code that attempts to create delegate using
S<__Canon>.M, which is not allowed.