Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

mikem8361
Copy link

By initializing m_rgHijackFunction to NULL.

…failure"

By initializing m_rgHijackFunction to NULL.
@mikem8361
Copy link
Author

@noahfalk, @jkotas and @sergiy-k code review?

@gregg-miskelly can you verify this fixes the problem?

@gregg-miskelly
Copy link

Linux is verified. I am working on verifying OSX.

@mikem8361
Copy link
Author

Thanks.

@gregg-miskelly
Copy link

OSX works as well. Woohoo!

@mellinoe
Copy link

OSX CI failed. Is that expected?

@mikem8361
Copy link
Author

The OSX test failure was a paltest:
foo 0000bfoo bfoo b.foo 42foo 65535foo -1foo 42foo 42foo 42foo 42 foo 42foo 042foo 042foo 42foo +42foo 42foo -42foo -42.foo 42foo 65535foo -1foo 42foo 42foo 42foo 42 foo 42foo 042foo 042foo 42foo +42foo 42foo -42foo -42..............Testing for 64 Bit Platforms
17:42:51 ..................Testing for 64 Bit Platforms
17:42:51 ...............................hello world..................................Testing for 64 Bit Platforms
17:42:53 ..................Testing for 64 Bit Platforms
17:42:53 .......................Testing for 64 Bit Platforms
17:42:54 ..................Testing for 64 Bit Platforms
17:42:54 ..........................................................................................................DeleteFileA: ERROR: Couldn't delete DeleteFileA's "testFile01.txt"
17:42:57
17:42:57
17:42:57 FAILED: file_io/DeleteFileA/test1/paltest_deletefilea_test1. Exit code: 1
17:42:57

This has nothing to do with my change and it passed locally. Rerunning the OSX leg.

@mikem8361
Copy link
Author

@dotnet-bot test OSX x64 Checked Build and Test

@noahfalk
Copy link
Member

lgtm

@joshfree joshfree merged commit fc416c3 into dotnet:release/1.0.0-rc2 Mar 31, 2016
@mikem8361 mikem8361 deleted the issue3987-rc2 branch March 31, 2016 03:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants