Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

ARM64: Enable a gcstress private job #6054

Merged
merged 1 commit into from
Jun 29, 2016
Merged

ARM64: Enable a gcstress private job #6054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions netci.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,15 @@ def static addTriggers(def job, def branch, def isPR, def architecture, def os,
// GCStress=C is currently not supported on OS X
if (os != 'CentOS7.1' && os != 'OSX' && !(os in bidailyCrossList)) {
assert (os == 'Windows_NT') || (os in Constants.crossList)
Utilities.addPeriodicTrigger(job, '@weekly')
if (architecture == 'arm64') {
assert (os == 'Windows_NT')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: assert is unnecessary it is already tested on 508.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well. This is intentional. arm64 is enabled only for Windows not cross OSes, yet.

// TODO: Enable a periodic trigger after tests are updated.
// Utilities.addPeriodicTrigger(job, '@daily')
// addEmailPublisher(job, 'dotnetonarm64@microsoft.com')
}
else {
Utilities.addPeriodicTrigger(job, '@weekly')
}
}
break
default:
Expand Down Expand Up @@ -1060,7 +1068,7 @@ def static addTriggers(def job, def branch, def isPR, def architecture, def os,
}
break
case 'arm64':
assert (scenario == 'default') || (scenario == 'pri1r2r')
assert (scenario == 'default') || (scenario == 'pri1r2r') || (scenario == 'gcstress0xc')

// Set up a private trigger
def contextString = "${os} ${architecture} Cross ${configuration}"
Expand All @@ -1081,6 +1089,7 @@ def static addTriggers(def job, def branch, def isPR, def architecture, def os,
"(?i).*test\\W+${os}\\W+${architecture}\\W+${configuration}", null, arm64Users)
break
case 'pri1r2r':
case 'gcstress0xc':
Utilities.addPrivateGithubPRTriggerForBranch(job, branch, contextString,
"(?i).*test\\W+${os}\\W+${architecture}\\W+${configuration}\\W+${scenario}", null, arm64Users)
break
Expand Down Expand Up @@ -1314,9 +1323,17 @@ combinedScenarios.each { scenario ->
return
}

// No stress modes except on x64 right now (mainly because of bad test state on x86)
if (architecture != 'x64') {
return
switch (architecture) {
case 'arm64':
if (scenario != 'gcstress0xc') {
return
}
break
case 'x64':
// Everything implemented
break
default:
return
}
}
else {
Expand Down Expand Up @@ -1632,10 +1649,7 @@ combinedScenarios.each { scenario ->

break
case 'arm64':
assert (scenario == 'default') || (scenario == 'pri1r2r')

// Up the timeout for arm64 jobs.
Utilities.setJobTimeout(newJob, 240);
assert (scenario == 'default') || (scenario == 'pri1r2r') || (scenario == 'gcstress0xc')

// Debug runs take too long to run. So build job only.
if (lowerConfiguration == "debug") {
Expand Down