Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

ghost
Copy link

@ghost ghost commented Jul 16, 2016

Fix dotnet/corefx#2578

@ghost
Copy link
Author

ghost commented Jul 16, 2016

@AlexGhiondea, @justinvp, please take a look and let me know where to add tests for this addition. :)

@justinvp
Copy link

justinvp commented Jul 17, 2016

model.xml needs to be updated with the new constructor.

After that, the following will need to happen:

  1. Porting the change to Lazy.cs in the CoreRT repo.
  2. Updating the contract (ref assembly) for System.Runtime in the CoreFX repo and incrementing the version as appropriate. I'm not sure how versioning of System.Runtime is being handled (i.e. when we're able to add new APIs to this contract), but this may have to wait until the new Lazy constructor is added to a future version of the desktop framework.

Fix dotnet/corefx#2578
@ghost
Copy link
Author

ghost commented Jul 17, 2016

@justinvp, thanks. I have updated model.xml and opened a PR in CoreRT repo dotnet/corert#1538.

@jkotas
Copy link
Member

jkotas commented Jul 18, 2016

@AlexGhiondea is offline till September.
cc @danmosemsft @weshaggard

Looks like this was approved in dotnet/corert#1538 and it is pretty straightforward. LGTM.

This will need to a special care on TFS side, so whoever merges it needs to be prepared to take care of it. (I cannot take care of it at the moment.)

@danmoseley
Copy link
Member

If the question for me was versioning of the corefx contract - I don't know when that will happen as it's not clear when the larger API work will get into master. This change LGTM though.

@danmoseley
Copy link
Member

(And such versioning can happen w/o the larger APi work of course.)

@jkotas jkotas merged commit e977438 into dotnet:master Jul 18, 2016
@ghost ghost deleted the feature/lazy-t-val-overload-ctor branch July 18, 2016 19:04
@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions and removed api addition labels Mar 17, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Fix dotnet/corefxdotnet/coreclr#2578

Commit migrated from dotnet/coreclr@e977438
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Product code improvement that does NOT require public API changes/additions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants