Enable PGO for release/1.1.0 on Windows x64 #7805
Conversation
(Porting commit 114b588 to release/1.1.0) Update the cmake build system to enable support for Profile Guided Optimization (PGO) on Windows, and enable this feature for two target binaries (coreclr and clrjit). With this change, toggle between instrumented and profile-optimized settings for target binaries by passing pgoinstrument argument to the build.cmd Assume profile-optimized mode by default. Fall back to regular non-PGO optimized builds if profile data is not available.
Restore optimization data from nuget prior to the native build. Update PGO implementation to consume the data from the restored package.
|
@brianrob FYI |
|
@dotnet-bot test Windows_NT arm64 release |
|
LGTM |
dpodder
changed the title
| ) | ||
|
|
||
| # Enable PGO only for optimized configs | ||
| set(ConfigTypeList RELEASE RELWITHDEBINFO) |
There was a problem hiding this comment.
This would have no effect on single config generators like Unix make generator. In that case, there is just single LINK_FLAGS property, not LINK_FLAGS_xxx per each config.
So for Unix, you'll need to use if (UPPERCASE_CMAKE_BUILD_TYPE STREQUAL RELEASE OR UPPERCASE_CMAKE_BUILD_TYPE STREQUAL RELWITHDEBINFO) and add to LINK_FLAGS if it is true.
So I would just put the whole body of the add_pgo under if(WIN32) for now.
There was a problem hiding this comment.
Thanks for the feedback, @janvorli. Unfortunate behavior, but I agree with the conclusion. Fixed here, and we'll make the change in master in a subsequent PR.
|
@gkhanna79 ARM64 test seems to have failed with an infra issue. Here's the previous result; could you help take a look? https://ci.dot.net/job/dotnet_coreclr/job/release_1.1.0/job/arm64_cross_release_windows_nt_prtest/1/ |
|
@jashook Have you seen the above failure in your CI resumption effort? |
|
LGTM |
|
@dpodder I am really sorry, I have missed the fact that this is a port of the previous change to the release branch. In that case, we should not be making the change I've suggested here. Could you please revert it? |
|
@janvorli No worries, easy enough. I rolled back the last commit, and will make the change later in |
Enable PGO for release/1.1.0 on Windows x64
Port changes from #7423 to release branch, which adds support for PGO to
coreclr.dll and clrjit.dll. Apply additional changes to actually
download and consume optimization profile data during a release build.
These changes together enable PGO on coreclr.dll and clrjit.dll, with
the following performance wins (measured on ASP.NET MusicStore):
dotnet buildby about 12%dotnet application.dlltime-to-main by 15%