This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Updating External dependencies to servicing-25002-00 #9267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyAyersMS
added a commit
to AndyAyersMS/coreclr
that referenced
this pull request
Feb 7, 2017
This gets the devirtualization part of the default pattern from dotnet#9267. Once we inline we can see the return value is more strongly typed and can enable devirtualization. How exactly we repair the call node at that point is still work in progress, though what is there seems to "work" well enough. Also, handle cases where the dispatch obj is wrapped in COMMA (as it is in the default pattern case because the static field access in the return includes a helper call to ensure class init).
AndyAyersMS
added a commit
to AndyAyersMS/coreclr
that referenced
this pull request
Feb 17, 2017
This gets the devirtualization part of the default pattern from dotnet#9267. Once we inline we can see the return value is more strongly typed and can enable devirtualization. How exactly we repair the call node at that point is still work in progress, though what is there seems to "work" well enough. Also, handle cases where the dispatch obj is wrapped in COMMA (as it is in the default pattern case because the static field access in the return includes a helper call to ensure class init).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @dotnet/coreclr-auto-update-notify