Restore System.Reflection.Assembly load APIs

[sepidehkh]

These APIs need to be exposed from System.Reflection:

M:System.Reflection.Assembly.Load(byte[],byte[],System.Security.Policy.Evidence)
M:System.Reflection.Assembly.Load(byte[],byte[],System.Security.SecurityContextSource)
M:System.Reflection.Assembly.Load(System.Reflection.AssemblyName,System.Security.Policy.Evidence)
M:System.Reflection.Assembly.Load(System.String,System.Security.Policy.Evidence)
M:System.Reflection.Assembly.LoadFrom(System.String)
M:System.Reflection.Assembly.LoadFrom(System.String,byte[],System.Configuration.Assemblies.AssemblyHashAlgorithm)
M:System.Reflection.Assembly.LoadFrom(System.String,System.Security.Policy.Evidence)
M:System.Reflection.Assembly.LoadFrom(System.String,System.Security.Policy.Evidence,byte[],System.Configuration.Assemblies.AssemblyHashAlgorithm)
M:System.Reflection.Assembly.LoadFile(System.String)
M:System.Reflection.Assembly.LoadFile(System.String,System.Security.Policy.Evidence)
M:System.Reflection.Assembly.LoadModule(System.String,byte[])
M:System.Reflection.Assembly.LoadModule(System.String,byte[],byte[])
M:System.Reflection.Assembly.LoadWithPartialName(System.String)
M:System.Reflection.Assembly.LoadWithPartialName(System.String,System.Security.Policy.Evidence)
M:System.Reflection.Assembly.UnsafeLoadFrom(System.String)

[sepidehkh]

The following are also missing NativeAssembly implementation:

M:System.Reflection.Assembly.get_EscapedCodeBase
M:System.Reflection.Assembly.get_GlobalAssemblyCache
M:System.Reflection.Assembly.get_HostContext
M:System.Reflection.AssemblyName.get_EscapedCodeBase

@rahku Could you please take care of these as well? Thanks.

[rahku]

will not be doing these as they are related to CAS
M:System.Reflection.Assembly.Load(byte[],byte[],System.Security.Policy.Evidence)
M:System.Reflection.Assembly.Load(byte[],byte[],System.Security.SecurityContextSource)
M:System.Reflection.Assembly.Load(System.Reflection.AssemblyName,System.Security.Policy.Evidence)
M:System.Reflection.Assembly.Load(System.String,System.Security.Policy.Evidence)
M:System.Reflection.Assembly.LoadFrom(System.String,System.Security.Policy.Evidence)
M:System.Reflection.Assembly.LoadFrom(System.String,System.Security.Policy.Evidence,byte[],System.Configuration
M:System.Reflection.Assembly.LoadFile(System.String,System.Security.Policy.Evidence)
M:System.Reflection.Assembly.LoadWithPartialName(System.String,System.Security.Policy.Evidence)

[rahku]

Below is the final list to be implemented:
M:System.Reflection.Assembly.LoadFrom(System.String)
M:System.Reflection.Assembly.LoadFrom(System.String,byte[],System.Configuration.Assemblies.AssemblyHashAlgorithm)
M:System.Reflection.Assembly.LoadFile(System.String)
M:System.Reflection.Assembly.LoadModule(System.String,byte[])
M:System.Reflection.Assembly.LoadModule(System.String,byte[],byte[])
M:System.Reflection.Assembly.LoadWithPartialName(System.String)
M:System.Reflection.Assembly.UnsafeLoadFrom(System.String)
M:System.Reflection.Assembly.get_EscapedCodeBase
M:System.Reflection.Assembly.get_GlobalAssemblyCache
M:System.Reflection.Assembly.get_HostContext
M:System.Reflection.AssemblyName.get_EscapedCodeBase

[sepidehkh]

I could not add M:System.Reflection.MethodBase.get_IsSecuritySafeCritical to mscorlib either. CrossGen fails when adding this API. I believe there is something missing from VM in this case, although I couldn't get much information about it from the failure.

[rahku]

@danmosemsft @weshaggard is it fine to not implement CAS specific apis load apis listed here https://github.com/dotnet/corefx/issues/11655#issuecomment-247117297

[danmoseley]

@rahku The authority is what's in https://github.com/dotnet/standard/tree/master/netstandard/ref in this case https://github.com/dotnet/standard/blob/master/netstandard/ref/mscorlib.appdomain.cs is where AppDomain is defined and it omits the CAS overloads.

[rahku]

@danmosemsft this issue is for reflection apis not appdomain. I found System.Reflection namespace in https://github.com/dotnet/standard/blob/master/netstandard/ref/mscorlib.cs and that omits CAS overloads. Thanks for the pointer.

[rahku]

CC @kouvel

[danmoseley]

P:System.Reflection.Assembly.EscapedCodeBase
M:System.Reflection.Assembly.get_EscapedCodeBase
P:System.Reflection.Assembly.GlobalAssemblyCache
M:System.Reflection.Assembly.get_GlobalAssemblyCache
P:System.Reflection.Assembly.HostContext
M:System.Reflection.Assembly.get_HostContext
P:System.Reflection.Assembly.IsFullyTrusted
M:System.Reflection.Assembly.get_IsFullyTrusted
P:System.Reflection.Assembly.SecurityRuleSet
M:System.Reflection.Assembly.get_SecurityRuleSet
M:System.Reflection.Assembly.GetFile(System.String)
M:System.Reflection.Assembly.GetFiles
M:System.Reflection.Assembly.GetFiles(System.Boolean)
M:System.Reflection.Assembly.LoadFile(System.String)
M:System.Reflection.Assembly.LoadFrom(System.String)
M:System.Reflection.Assembly.LoadFrom(System.String,System.Byte[],System.Configuration.Assemblies.AssemblyHashAlgorithm)
M:System.Reflection.Assembly.LoadModule(System.String,System.Byte[])
M:System.Reflection.Assembly.LoadModule(System.String,System.Byte[],System.Byte[])
M:System.Reflection.Assembly.LoadWithPartialName(System.String)
M:System.Reflection.Assembly.UnsafeLoadFrom(System.String)

[danmoseley]

@rahku Above is the list of what's left from NS2.0 -- GetFile(s) was missing from your list. Please check.

[AlexGhiondea]

@rahku do you know how much work is left here?

[rahku]

i have completed most of work in PR dotnet/corefx#7681

[rahku]

remaining is EscapedCodeBase and getFiles which has a dependency on FileStream which needs to move to corelib

[rahku]

I still need to expose it in corefx though

[danmoseley]

The following still remain missing from Assembly:

    public abstract class Assembly : ICustomAttributeProvider, ISerializable {
        public virtual string EscapedCodeBase { get; }
        public virtual FileStream GetFile(string name);
        public virtual FileStream[] GetFiles();
        public virtual FileStream[] GetFiles(bool getResourceModules);
        public virtual Module LoadModule(string moduleName, byte[] rawModule, byte[] rawSymbolStore);
    }

In the case of LoadModule it is present but misisng virtual