This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Fix ITextBufferWriter performance regression: ArrayFormatter.GetSpan should not go through GetMemory #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression observed in JsonWriter performance test: #2254
The following PR caused the regression: #2047 / 4bf5f6a - Jan 17, 2018
Was there a particular reason we went through
Memory<byte>to get the span? I am now getting the Span directly. If this is correct, we should make similar changes to all implementations of ITextBufferWriter (for example BufferWriterFormatter).This change improves JsonWriter performance by roughly 70% (before - 115 ms, after - 67 ms).
cc @pakrym, @KrzysztofCwalina, @davidfowl, @JeremyKuhne