This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Add the default globalization implementation for Linux #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkotas could you have a quick look before I merge this change please? |
|
Could you please name this as "CultureInfo.InvariantOnly.cs", etc., so that we can keep it around even once we add the proper globalization support for Unix? (Feel free to use better name for InvariantOnly if you can think about one.) |
| @@ -324,6 +331,10 @@ public static CultureInfo CurrentUICulture | |||
| { | |||
| get | |||
| { | |||
| #if CORERT | |||
There was a problem hiding this comment.
Could you please make sure that the Hello world still works on Windows with these changes? I suspect that we may want to use the dummy CultureInfo implementations even on CoreRT/Windows, for now.
|
LGTM otherwise. Could you please squash into single commit before merging? |
The change here is just adding some default implmentation to be used for Linux so we can avoid calling any path end up calling Win32 API. The change also will make it easier in the future to determine what functionality needed for Linux to implement the real PAL layer. Note that, the changes here cover most of the globalization implemntation but we may need to do more as needed if we run into any other problem when getting the demo ready
tarekgh
added a commit
that referenced
this pull request
Oct 24, 2015
Add the default globalization implementation for Linux
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change here is just adding some default implmentation to be used for
Linux so we can avoid calling any path end up calling Win32 API.
The change also will make it easier in the future to determine what
functionality needed for Linux to implement the real PAL layer.
Note that, the changes here cover most of the globalization implemntation but
we may need to do more as needed if we run into any other problem when getting
the demo ready