Add support for nullable array types (fixes #157) #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JoeRobich
added a commit
to JoeRobich/vscode
that referenced
this pull request
Mar 24, 2021
C# 8 support [csharp-tmLanguage#165](dotnet/csharp-tmLanguage#165): - Pattern matching enhancements - Switch Expressions - Property Patterns - Tuple Patterns - Positional Patterns - Asynchronous streams. - Enhancement of interpolated verbatim strings. _(Contributed by [@david-driscoll](https://github.com/david-driscoll))_ Additional C# 8 support [csharp-tmLanguage#188](dotnet/csharp-tmLanguage#188): - Using Declarations. - Static Local Functions. - Null-coalescing Assignment. _(Contributed by [@rchowe](https://github.com/rchowe))_ Add support for Nullable Array types [csharp-tmLanguage#175](dotnet/csharp-tmLanguage#175) _(Contributed by [@GeorchW](https://github.com/GeorchW))_
JoeRobich
added a commit
to JoeRobich/vscode
that referenced
this pull request
Mar 24, 2021
C# 8 support: - Pattern matching enhancements - Switch Expressions - Property Patterns - Tuple Patterns - Positional Patterns - Asynchronous streams. - Enhancement of interpolated verbatim strings. [csharp-tmLanguage#165](dotnet/csharp-tmLanguage#165) _(Contributed by [@david-driscoll](https://github.com/david-driscoll))_ Additional C# 8 support: - Using Declarations. - Static Local Functions. - Null-coalescing Assignment. [csharp-tmLanguage#188](dotnet/csharp-tmLanguage#188) _(Contributed by [@rchowe](https://github.com/rchowe))_ Add support for Nullable Array types. [csharp-tmLanguage#175](dotnet/csharp-tmLanguage#175) _(Contributed by [@GeorchW](https://github.com/GeorchW))_
JoeRobich
added a commit
to JoeRobich/vscode
that referenced
this pull request
Mar 24, 2021
C# 8 support (Pattern matching enhancements, Asynchronous streams, Enhancement of interpolated verbatim strings) [csharp-tmLanguage#165](dotnet/csharp-tmLanguage#165) _(Contributed by [@david-driscoll](https://github.com/david-driscoll))_ Additional C# 8 support (Using Declarations, Static Local Functions, Null-coalescing Assignment) [csharp-tmLanguage#188](dotnet/csharp-tmLanguage#188) _(Contributed by [@rchowe](https://github.com/rchowe))_ Add support for Nullable Array types. [csharp-tmLanguage#175](dotnet/csharp-tmLanguage#175) _(Contributed by [@GeorchW](https://github.com/GeorchW))_
JoeRobich
added a commit
to JoeRobich/vscode
that referenced
this pull request
Mar 24, 2021
C# 8 support (Pattern matching enhancements, Asynchronous streams, Enhancement of interpolated verbatim strings) [csharp-tmLanguage#165](dotnet/csharp-tmLanguage#165) _(Contributed by [@david-driscoll](https://github.com/david-driscoll))_ Additional C# 8 support (Using Declarations, Static Local Functions, Null-coalescing Assignment) [csharp-tmLanguage#188](dotnet/csharp-tmLanguage#188) _(Contributed by [@rchowe](https://github.com/rchowe))_ Add support for Nullable Array types. [csharp-tmLanguage#175](dotnet/csharp-tmLanguage#175) _(Contributed by [@GeorchW](https://github.com/GeorchW))_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incurs lots of changes because the type regex was changed; there is only one line that was uniquely changed*.
I think this should be all that is required for the "nullable reference types" feature of C#8, since arrays are the only type (if I'm not mistaken) that are reference types distinguishable by syntax, and nullable value types already existed before.
* edit: I split the line into multiple for readability.
Fixes #157