Skip to content

Fixes issue with execution summary. Closes #416 #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2023
Merged

Fixes issue with execution summary. Closes #416 #417

merged 2 commits into from
Dec 18, 2023

Conversation

waldekmastykarz
Copy link
Collaborator

Fixes issue with execution summary. Closes #416

@waldekmastykarz waldekmastykarz added the pr-bugfix Fixes a bug label Dec 12, 2023
@waldekmastykarz waldekmastykarz requested a review from a team December 12, 2023 13:25
garrytrinder
garrytrinder reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@garrytrinder garrytrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing unknown requests in my testing.

image

Proxy started with no args and using default devproxyrc.json configuration with the exception of ExecutionSummaryPlugin enabled.

@waldekmastykarz
Copy link
Collaborator Author

I can't reproduce your issue following the steps you described. Could you please have another look?

garrytrinder
garrytrinder approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@garrytrinder garrytrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue was my end, working as expected.

image

@garrytrinder garrytrinder merged commit f764fa6 into dotnet:main Dec 18, 2023
@waldekmastykarz waldekmastykarz deleted the fix-summary-intercepted-response branch December 18, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrytrinder garrytrinder garrytrinder approved these changes

Assignees
No one assigned
Labels
pr-bugfix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: "Unknown" items reported in the execution summary
2 participants
@waldekmastykarz @garrytrinder