Skip to content

Fixes communicating retry-after in RateLimitingPlugin #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fixes communicating retry-after in RateLimitingPlugin #497

merged 1 commit into from
Jan 17, 2024

Conversation

waldekmastykarz
Copy link
Collaborator

@waldekmastykarz waldekmastykarz commented Jan 17, 2024 •
edited
Loading

  • communicates retry-after value using the remaining reset time
  • removes the unnecessary retry-after value from plugin configuration
  • adds support for specifying dynamic retry-after value on custom throttling response

@waldekmastykarz waldekmastykarz requested a review from a team January 17, 2024 07:54
@waldekmastykarz waldekmastykarz added the pr-bugfix Fixes a bug label Jan 17, 2024
@garrytrinder garrytrinder merged commit 1e6e9dd into dotnet:main Jan 17, 2024
@waldekmastykarz waldekmastykarz deleted the fix-ratelimit branch January 17, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrytrinder garrytrinder garrytrinder approved these changes

Assignees
No one assigned
Labels
pr-bugfix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waldekmastykarz @garrytrinder