Skip to content

Makes the retry-after value in GenericRandomErrorPlugin configurable. Closes #520 #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Makes the retry-after value in GenericRandomErrorPlugin configurable. Closes #520 #537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2893326
Makes the retry-after value in GenericRandomErrorPlugin configurable.…
waldekmastykarz Jan 29, 2024
6b35b67
Merge branch 'main' into genericrandomerror-retryafter
waldekmastykarz Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dev-proxy-plugins/RandomErrors/GenericRandomErrorPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ internal enum GenericRandomErrorFailMode
public class GenericRandomErrorConfiguration
{
public string? ErrorsFile { get; set; }
public int RetryAfterInSeconds { get; set; } = 5;
[JsonPropertyName("responses")]
public IEnumerable<GenericErrorResponse> Responses { get; set; } = Array.Empty<GenericErrorResponse>();
}
Expand All @@ -34,7 +35,6 @@ public class GenericRandomErrorPlugin : BaseProxyPlugin

public override string Name => nameof(GenericRandomErrorPlugin);

private const int retryAfterInSeconds = 5;
private readonly Random _random;

public GenericRandomErrorPlugin()
Expand All @@ -55,7 +55,7 @@ private void FailResponse(ProxyRequestArgs e, GenericRandomErrorFailMode failMod
private ThrottlingInfo ShouldThrottle(Request request, string throttlingKey)
{
var throttleKeyForRequest = BuildThrottleKey(request);
return new ThrottlingInfo(throttleKeyForRequest == throttlingKey ? retryAfterInSeconds : 0, "Retry-After");
return new ThrottlingInfo(throttleKeyForRequest == throttlingKey ? _configuration.RetryAfterInSeconds : 0, "Retry-After");
}

private void UpdateProxyResponse(ProxyRequestArgs e, GenericErrorResponse error)
Expand All @@ -72,7 +72,7 @@ private void UpdateProxyResponse(ProxyRequestArgs e, GenericErrorResponse error)
error.Headers is not null &&
error.Headers.FirstOrDefault(h => h.Name == "Retry-After" || h.Name == "retry-after")?.Value == "@dynamic")
{
var retryAfterDate = DateTime.Now.AddSeconds(retryAfterInSeconds);
var retryAfterDate = DateTime.Now.AddSeconds(_configuration.RetryAfterInSeconds);
if (!e.GlobalData.ContainsKey(RetryAfterPlugin.ThrottledRequestsKey))
{
e.GlobalData.Add(RetryAfterPlugin.ThrottledRequestsKey, new List<ThrottlerInfo>());
Expand All @@ -82,7 +82,7 @@ error.Headers is not null &&
// replace the header with the @dynamic value with the actual value
var h = headers.First(h => h.Name == "Retry-After" || h.Name == "retry-after");
headers.Remove(h);
headers.Add(new("Retry-After", retryAfterInSeconds.ToString()));
headers.Add(new("Retry-After", _configuration.RetryAfterInSeconds.ToString()));
}

var statusCode = (HttpStatusCode)error.StatusCode;
Expand Down