Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on single file #1709

Merged
merged 6 commits into from
Nov 10, 2020

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Nov 10, 2020

Fixes #344

@hoyosjs hoyosjs requested a review from a team as a code owner November 10, 2020 10:52
@hoyosjs
Copy link
Member Author

hoyosjs commented Nov 10, 2020

@shirhatti @josalem @noahfalk This is a quick guide on the single file tools. It's a bit crude, but I wanted to get something to review.

Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Juan, this doc looks great : ) We'll still need to get content on docs.microsoft.com to make it more discoverable but having something we can point at in our repo is a great start.

documentation/single-file-tools.md Outdated Show resolved Hide resolved
documentation/single-file-tools.md Outdated Show resolved Hide resolved
Copy link
Contributor

@josalem josalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to start advertising this shipping vehicle 😁

documentation/single-file-tools.md Outdated Show resolved Hide resolved
documentation/single-file-tools.md Outdated Show resolved Hide resolved
documentation/single-file-tools.md Outdated Show resolved Hide resolved
documentation/single-file-tools.md Show resolved Hide resolved
documentation/single-file-tools.md Outdated Show resolved Hide resolved
hoyosjs and others added 4 commits November 10, 2020 11:28
Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
Co-authored-by: John Salem <josalem@microsoft.com>
Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉


1. *`curl` (available on Windows after 1706, macOS, and several distributions of Linux)*
```sh
curl -JLO https://aka.ms/dotnet-dump/win-x64
Copy link
Contributor

@sywhang sywhang Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add one of these into installation instruction on each tools' docs (i.e. dotnet-counters.md, dotnet-dump.md, dotnet-trace.md, etc.) as well? Or was there some explicit you didn't want to advertise it there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the documentation folder? I might link them to this doc. Just adding a single link doesn't give much information on the requirements. I was trying to think of a way to combine them, but didn't see an easy way to caveat the requirements.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok whether you include it there or just link it to this doc - just want this to be more discoverable since those docs are where people usually land.

3. *`pwsh` (PowerShell core)*

```powershell
$resp = Invoke-WebRequest -Uri "https://aka.ms/dotnet-dump/win-x86"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all these links different ones on purpose? It might be more straightforward for the reader if you stuck to one link and use it across the three different shells.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Powershell is only available on windows. I needed a windows link there. Wget is a downloadable tool, but it's not available by default on windows, so mostly that

@hoyosjs hoyosjs merged commit fb65a2c into dotnet:master Nov 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet tools are hard to deploy into production environments
4 participants