New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support customizing logo and favicon #892

Merged
merged 2 commits into from Nov 18, 2016

Conversation

Projects
None yet
7 participants
@superyyrrzz
Collaborator

superyyrrzz commented Nov 14, 2016

@vwxyzh

vwxyzh approved these changes Nov 14, 2016

@qinezh

qinezh approved these changes Nov 14, 2016

@hellosnow

This comment has been minimized.

Show comment
Hide comment
@hellosnow

hellosnow Nov 14, 2016

Collaborator

:shipit:

Collaborator

hellosnow commented Nov 14, 2016

:shipit:

@roji

This comment has been minimized.

Show comment
Hide comment
@roji

roji Nov 14, 2016

This is great, but note that it still imposes class="svg" (I'm not sure what that means in your CSS and whether it's possible to put in a png etc.).

One idea, probably in addition to this PR, is to extract the logo into its own separate partial, allowing people to override it with whatever they want without having to duplicate the rest of the navbar.

roji commented Nov 14, 2016

This is great, but note that it still imposes class="svg" (I'm not sure what that means in your CSS and whether it's possible to put in a png etc.).

One idea, probably in addition to this PR, is to extract the logo into its own separate partial, allowing people to override it with whatever they want without having to duplicate the rest of the navbar.

@superyyrrzz

This comment has been minimized.

Show comment
Hide comment
@superyyrrzz

superyyrrzz Nov 15, 2016

Collaborator

@roji We use svg class to provide hover effect in docfx.css. Putting a png here can also work. BTW, it's nice to have a logo partial.

Collaborator

superyyrrzz commented Nov 15, 2016

@roji We use svg class to provide hover effect in docfx.css. Putting a png here can also work. BTW, it's nice to have a logo partial.

@ansyral

This comment has been minimized.

Show comment
Hide comment
@ansyral

ansyral Nov 15, 2016

Contributor

:shipit:

Contributor

ansyral commented Nov 15, 2016

:shipit:

@superyyrrzz superyyrrzz merged commit 8fc36f2 into dotnet:dev Nov 18, 2016

1 check passed

continuous-integration/teamcity Finished TeamCity Build Docfx CI :: dev : Tests passed: 564, ignored: 2
Details

@superyyrrzz superyyrrzz deleted the superyyrrzz:logo branch Nov 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment