Allow official build and publish pipelines to run on internal/release/ branches #1836
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the branch validation logic to allow official build and publish pipelines to run on internal/release/ branches. The changes reorganize the validation steps to check official repo prefixes first, then official branches, and finally official branch prefixes instead of relying on a branch override feature.
Key changes:
- Restructures validation logic to check conditions in a cleaner order
- Adds support for official branch prefixes to allow internal/release/ branches
- Removes the branch override feature that was causing issues
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| foreach ($prefix in "$(officialBranchPrefixes)".Split(',')) { | ||
| if ("$(sourceBranch)".StartsWith($prefix)) { | ||
| $hasOfficialBranchPrefix = $true | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
The loop iterates through all prefixes even after finding a match. Consider adding trimming to handle potential whitespace in the comma-separated list, as Split(',') doesn't remove leading/trailing spaces from individual elements.
Copilot uses AI. Check for mistakes.
2 participants
This PR is dotnet/dotnet-docker#6713 but moved to the correct repo.
I addressed the review feedback from dotnet/dotnet-docker#6713 (comment) in a new commit.
This PR also fixes #1795 by removing the branch override feature as suggested in #1795 (comment).