Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High DPI support app.config sample typo #1485

Closed
afrowuk opened this issue Jul 26, 2022 · 0 comments · Fixed by #1495
Closed

High DPI support app.config sample typo #1485

afrowuk opened this issue Jul 26, 2022 · 0 comments · Fixed by #1495
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-framework/svc Pri1 High priority, do before Pri2 and Pri3 winforms/subsvc

Comments

@afrowuk
Copy link

afrowuk commented Jul 26, 2022 •
edited

The app.config sample on this page shows a root node of <compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">, but should have a <configuration> root node. I suspect this is a copy and paste typo from the app.manifest sample above it.

Edit: The following page has a correct app.config sample usage: https://docs.microsoft.com/en-us/dotnet/framework/configure-apps/file-schema/winforms/

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jul 26, 2022
@PRMerger20 PRMerger20 added dotnet-framework/svc winforms/subsvc Pri1 High priority, do before Pri2 and Pri3 labels Jul 26, 2022
amaitland added a commit to cefsharp/CefSharp that referenced this issue Aug 8, 2022
@amaitland
WinForms Example - Make DPI Aware
5cab3c2 
- WinForms Example is now DPI aware using https://docs.microsoft.com/en-us/dotnet/desktop/winforms/high-dpi-support-in-windows-forms?view=netframeworkdesktop-4.8
  There's a mistake in the MS Docs which was already reported at dotnet/docs-desktop#1485
- Toolstrip layout updated slightly, could use some more minor tweaks to better calculate size

Resolves #1543
@amaitland amaitland mentioned this issue Aug 8, 2022
Closed
@amaitland amaitland mentioned this issue Aug 21, 2022
Closed
champnic added a commit to champnic/docs-desktop that referenced this issue Aug 22, 2022
@champnic
Fix Winforms High DPI sample configuration
d8e3d69 
We got pinged on the WebView2 repo about a bug in the HighDPI sample that was confusing our users:
MicrosoftEdge/WebView2Feedback#1700 (comment)

Here's the related issue on the dotnet/docs-desktop repo:
dotnet#1485

The fix is to change the <compatibility> tag with the correct <configuration> tag.
@champnic champnic mentioned this issue Aug 22, 2022
Merged
@adegeo adegeo added the doc-bug Problem with the content; needs to be fixed [org][type][category] label Aug 29, 2022
@dotnet-bot dotnet-bot removed the ⌚ Not Triaged Not triaged label Aug 29, 2022
adegeo pushed a commit that referenced this issue Aug 29, 2022
@champnic
Fix Winforms High DPI sample configuration (#1495)
646836a 
We got pinged on the WebView2 repo about a bug in the HighDPI sample that was confusing our users:
MicrosoftEdge/WebView2Feedback#1700 (comment)

Here's the related issue on the dotnet/docs-desktop repo:
#1485

The fix is to change the <compatibility> tag with the correct <configuration> tag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-framework/svc Pri1 High priority, do before Pri2 and Pri3 winforms/subsvc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Winforms High DPI sample configuration champnic/docs-desktop
4 participants
@dotnet-bot @afrowuk @PRMerger20 @adegeo