-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics] List of metrics built into .NET #36748
Comments
I'd propose to have the list include ASP.NET Core metrics because I imagine that is simpler for users and follows precedent we already set with EventCounters. Does that sound good or do you see a particular benefit in separating them? |
I think having them in the same document (or child doc if all counters are too much for one doc) is fine. They just need to be grouped under an ASP.NET Core section that we can link to from ASP.NET Core docs. If it turns out to be a problem in the future then it's simple to change. |
@noahfalk @antonfirsov @joperezr @Rick-Anderson @lmolkova I updated the issue with a proposal for displaying built-in metrics in our docs. Feedback welcome. I also added a list of tasks to complete. |
What you suggested seems fine. I'll probably have a better sense for it once I've got an initial draft after which feedback is welcome. Its still in my todo list, just not at the top quite yet, almost there. |
Part of the work for dotnet#36748
Part of the work for dotnet#36748
* Add a reference for new .NET 8 metrics Part of the work for #36748 --------- Co-authored-by: Anton Firszov <antonfir@gmail.com>
@Rick-Anderson - now that #37213 is merged and you are taking over on editing, mind if I assign this issue to you? I think the remaining work is mostly editing and cross-referencing once all the content is live. |
https://learn.microsoft.com/en-us/dotnet/core/diagnostics/metrics should have a list of metrics built into .NET. This would be like the well-known counters page - https://learn.microsoft.com/en-us/dotnet/core/diagnostics/available-counters.
For each meter name, there should be a table with the counter names, descriptions, .NET added versions. The counter name could link to OTel semantic conventions site. That allows people to see more information about the counter and its attributes.
Open question: Should the list here be just the dotnet/runtime metrics, or should it include ASP.NET Core metrics?
Proposal:
Items:
The text was updated successfully, but these errors were encountered: