Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-GA, include all C# 12 speclets #36932

Closed
BillWagner opened this issue Aug 31, 2023 · 0 comments · Fixed by #37891
Closed

Post-GA, include all C# 12 speclets #36932

BillWagner opened this issue Aug 31, 2023 · 0 comments · Fixed by #37891
Assignees
@BillWagner
Labels
okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. Pri1 High priority, do before Pri2 and Pri3 resolved-by-customer Indicates issues where the customer no longer needs any help. [org][resolution]

Comments

@BillWagner
Copy link
Member

During the preview cycle, we included each C# 12 spec by name, rather than the entire folder.

Once GA has happened, include all speclets by default.
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Aug 31, 2023
@BillWagner BillWagner self-assigned this Aug 31, 2023
@BillWagner BillWagner added okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. Pri1 High priority, do before Pri2 and Pri3 and removed ⌚ Not Triaged Not triaged Pri3 labels Aug 31, 2023
BillWagner added a commit to BillWagner/docs that referenced this issue Aug 31, 2023
@BillWagner
only include specified C# 12 speclets
46e69dc 
To avoid build warnings, only include the currently published C# 12 speclets in the build, rather than all speclets.

See dotnet#36932 for when this should be reverted.
@BillWagner BillWagner mentioned this issue Aug 31, 2023
Merged
BillWagner added a commit that referenced this issue Aug 31, 2023
@BillWagner
only include specified C# 12 speclets (#36933)
02bab08 
* only include specified C# 12 speclets

To avoid build warnings, only include the currently published C# 12 speclets in the build, rather than all speclets.

See #36932 for when this should be reverted.

* add experimental attribute

Add the experimental attribute back in.

It's not in the TOC yet, but I'll add it shortly.
@BillWagner BillWagner moved this from 🔖 Ready to 🏗 In progress in dotnet/docs November 2023 sprint Nov 3, 2023
@BillWagner BillWagner mentioned this issue Nov 3, 2023
Merged
@ghost ghost added the in-pr This issue will be closed (fixed) by an active pull request. label Nov 3, 2023
@BillWagner BillWagner moved this from 🏗 In progress to 👀 In review in dotnet/docs November 2023 sprint Nov 3, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in dotnet/docs November 2023 sprint Nov 7, 2023
@dotnet-bot dotnet-bot added the resolved-by-customer Indicates issues where the customer no longer needs any help. [org][resolution] label Nov 7, 2023
@ghost ghost removed the in-pr This issue will be closed (fixed) by an active pull request. label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillWagner BillWagner

Labels
okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. Pri1 High priority, do before Pri2 and Pri3 resolved-by-customer Indicates issues where the customer no longer needs any help. [org][resolution]
Projects
No open projects
dotnet/docs November 2023 sprint
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

glob the C# 12 speclets BillWagner/docs
2 participants
@BillWagner @dotnet-bot