C# Versioning #1197

tonerdo · 2016-11-01T15:36:18Z

This PR adds content for C# Versioning.

Changes include:

Explanation of why versioning is important
Introduction and example usage of each versioning modifier

Fixes #56

saldana · 2016-11-01T15:47:47Z

Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:

Docset 1 - core-docs
https://review.docs.microsoft.com/en-us/dotnet/articles/csharp/versioning?branch=pr-en-us-1197

Status: SucceededWithWarning. Message: Warning occurred: docs/csharp/csharp-7.md contains illegal link: #local-expressions. The file docs/csharp/csharp-7.md doesn't contain a bookmark named local-expressions...
Open Publishing Report.

saldana · 2016-11-01T15:59:26Z

Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:

Docset 1 - core-docs
https://review.docs.microsoft.com/en-us/dotnet/articles/csharp/versioning?branch=pr-en-us-1197

Status: SucceededWithWarning. Message: Warning occurred: docs/core/tools/project-json.md contains illegal link: #supressParent. The file docs/core/tools/project-json.md doesn't contain a bookmark named supressParent...
Open Publishing Report.

BillWagner · 2016-11-04T14:17:33Z

@tsolarin Sorry for a delay on this. I was traveling. I'll get lots of feedback today.

BillWagner · 2016-11-06T19:27:42Z

@tsolarin This is a good start. I'm going to make conceptual comments, rather than review it line by line.

First, we've added a continuous integration service that builds all the code from all the samples. docfx supports an include syntax so you can add the full sample code to the repository. That way, it gets built and we ensure there are no errors. The include syntax enables parts of the sample to be published in the article. See the updates in PR #1209 for the syntax for the includes. The contributing guide contains information on where to put sample code so the CI build will find them.

The article as it stands reads more about override and object oriented techniques than about versioning. We need to organize the material differently to make the versioning information stand out. I'd lead with a discussion of semantic versioning including a link to semver.org. That describes guidelines for updating an assembly. I'd discuss the element in app.config and how that enables runtime updates without recompiling.

Next, I'd discuss the new modifier, and how that enables resiliency of derived classes when base classes are updated. A key reason for the new modifier is that you can use it to hid a method in an updated version of a base class.

Finally, I'd only briefly discuss override, and I'd limit that discussion to how it behaves differently than the new modifier. (runtime vs. compile time binding)

If you have any questions, just message me here. And thank you again for all the continued contributions.

BillWagner · 2016-11-06T20:19:55Z

Added the Work in Progress (WIP) label pending the next draft.

tonerdo · 2016-11-06T22:56:29Z

@BillWagner thanks for the review, I'll take a look at code inclusion you mentioned. I also would like to mention that the file I'm working with has no documentation metadata like the others I've worked with, how do I fix this?

I'll start working on the next draft based on your recommendations

BillWagner · 2016-11-06T23:08:55Z

Here's a block you can use:

---
title: C# Versioning | C# Guide
description: Understand how versioning works in C# and .NET
keywords: .NET, .NET Core, C#
author:  tsolarin
manager: wpickett
ms.author: wiwagn
ms.date: 2016/11/06
ms.topic: article
ms.prod: visual-studio-dev-14
ms.technology: devlang-csharp
ms.devlang: csharp
ms.assetid: aa8732d7-5cd0-46e1-994a-78017f20d861
---

saldana · 2016-11-06T23:35:05Z

Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:

Docset 1 - core-docs
https://review.docs.microsoft.com/en-us/dotnet/articles/csharp/versioning?branch=pr-en-us-1197

Status: SucceededWithWarning. Message: Warning occurred: articles/standard/base-types/extract-day.html contains illegal link: core/api/System.DateTime.html#System.DateTime.Parse(System.String). The file core/api/System.DateTime.html doesn't contain a bookmark named System.DateTime.Parse(System.String), please check the src file docs/standard/base-types/extract-day.md and src linkedTo file api_ref/System.DateTime.yml or the template you applied...
Open Publishing Report.

tonerdo · 2016-11-10T23:52:25Z

@BillWagner ready for another go

saldana · 2016-11-10T23:57:58Z

❌ Validation status: errors

File	Status	Details
docs/csharp/versioning.md	⚠️Warning	Details
docs/toc.md	✅Succeeded	Details
samples/csharp/versioning/new/Program.cs	✅Succeeded	Details
samples/csharp/versioning/new/README.md	✅Succeeded	Details
samples/csharp/versioning/new/project.json	✅Succeeded	Details
samples/csharp/versioning/override/Program.cs	✅Succeeded	Details
samples/csharp/versioning/override/README.md	✅Succeeded	Details
samples/csharp/versioning/override/project.json	✅Succeeded	Details

docs/csharp/versioning.md

Line 33: [Warning] Invalid file link:(~/docs/csharp/[http:/semver.org/]).

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

saldana · 2016-11-11T00:09:09Z

❌ Validation status: errors

File	Status	Details
docs/csharp/versioning.md	✅Succeeded	Details
docs/toc.md	✅Succeeded	Details
samples/csharp/versioning/new/Program.cs	✅Succeeded	Details
samples/csharp/versioning/new/README.md	✅Succeeded	Details
samples/csharp/versioning/new/project.json	✅Succeeded	Details
samples/csharp/versioning/override/Program.cs	✅Succeeded	Details
samples/csharp/versioning/override/README.md	✅Succeeded	Details
samples/csharp/versioning/override/project.json	✅Succeeded	Details

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

BillWagner · 2016-11-11T17:12:18Z

@tsolarin I'm flying most of the day today. I'll have comments by the end of the day on Monday.

BillWagner · 2016-11-14T22:59:11Z

@tsolarin Let's go one more content round. You've got much of the facts here, but the story is missing. This one could be hard, because there are really two stories:

What a library author should do to make it as easy as possible for library consumers to accept upgrades. That story includes sections on semantic versioning, using config files instead of hard coded data, and being very careful with backwards compatibitiliy.
What a library consumer needs to do to accept updates. This section would include how to drop in a patch version using app.config to redirect binding, when recompiling and re-deploying are necessary, and how to use new when updated libraries use a name you'd used.

The override section should be a sub-set of the second section, and its only purpose should be to explain how method binding works for new in contrast to virtual and override.

Does that make sense?

tonerdo · 2016-11-15T14:05:54Z

@BillWagner sure it does make a lot of sense. I was trying to merge building libraries and consuming libraries into one, I guess separating them out into sections will be much better. I'll get to working on another draft.

tonerdo · 2016-11-21T00:15:30Z

/cc @BillWagner ready for another go

saldana · 2016-11-21T00:29:27Z

✅ Validation status: passed

File	Status	Preview URL	Details
docs/csharp/versioning.md	✅Succeeded	View	Details
docs/toc.md	✅Succeeded	View	Details

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

BillWagner · 2016-11-23T19:40:52Z

@tsolarin I'll try to review this by the end of the week. With the American Thanksgiving, it might be early next week. Is that OK?

BillWagner

This is on the right track. I gave it a thorough review, and I think it's getting close. One more cycle, and I think we'll be down to a quick copy edit.

BillWagner · 2016-11-25T23:20:39Z

docs/csharp/versioning.md

+---
+
+# Versioning in C#
+


Let's add a brief introduction here to tell readers what they will learn by reading this article. One or two paragraphs is all it should take.

BillWagner · 2016-11-25T23:27:13Z

docs/csharp/versioning.md

+There are also ways to specify other scenarios like pre-release versions etc. Go [here](http://semver.org/) to get more information on SemVer
+and how best to utilize it when applying version information to your .NET library.
+
+### Application Configuration File


I'd move this section below the Backwards Compatibility section. I also think it needs a sample to demonstrate loading some data that changes the library's behavior.

BillWagner · 2016-11-25T23:28:01Z

docs/csharp/versioning.md

+
+As you release new versions of your library, backwards compatibility with previous versions will most likely be one of your major concerns.
+A new version of your library is source compatible with a previous version if code that depends on the previous version can, when recompiled, work with the new version. 
+In contrast, a new version of your library is binary compatible if an application that depended on the old version can, without recompilation, work with the new version.


I'd delete "In contrast". The two definitions read quite well without it.

BillWagner · 2016-11-25T23:29:26Z

docs/csharp/versioning.md

+will have to be updated.
+* Method signatures: When updating a method behaviour requires you to change it's signature as well, you should instead create an override so that derived classes calling into that method will still work.
+You can always manipulate the old method signature to call into the new method signature so that implementation remains consistent.
+* Optional Method Arguments: When you make previously optional method arguments compulsory then all code that does not supply those arguments will need to be updated.


You should mention that changing the default value of an argument can be a breaking change as well.

BillWagner · 2016-11-25T23:30:00Z

docs/csharp/versioning.md

+* Method signatures: When updating a method behaviour requires you to change it's signature as well, you should instead create an override so that derived classes calling into that method will still work.
+You can always manipulate the old method signature to call into the new method signature so that implementation remains consistent.
+* Optional Method Arguments: When you make previously optional method arguments compulsory then all code that does not supply those arguments will need to be updated.
+On the other hand making compulsory arguments optional should have very little effect especially if it doesn't change the method's behaviour.


This might read better as a Note. (See the style guide for the note style)

BillWagner · 2016-11-25T23:32:15Z

docs/csharp/versioning.md

+On the other hand making compulsory arguments optional should have very little effect especially if it doesn't change the method's behaviour.
+* Obsolete attribute: You can use this attribute in your code to specify classes or class members that are deprecated and likely to be removed in future versions.
+This ensures developers utilizing your library are better prepared for breaking changes. More info on the `Obsolete` attribute [here](https://msdn.microsoft.com/en-us/library/22kk2b44(v=vs.90).aspx).
+


I'd add a closing before you go on. Consider this point: the easier you make it for your users to upgrade to the new version of your library, the more likely that they will upgrade sooner.

BillWagner · 2016-11-25T23:32:59Z

docs/csharp/versioning.md

+
+### Assembly Binding Redirection
+
+You can use the `app.config` file to update the version of a library your app uses. By adding what is called a `binding redirect` your


You should style it binding redirect as a definition instead of binding redirect as a code style.

BillWagner · 2016-11-25T23:33:47Z

docs/csharp/versioning.md

+
+You can use the `app.config` file to update the version of a library your app uses. By adding what is called a `binding redirect` your
+can use the new library version without having to recompile your app. The following example shows how you would update
+your app's `app.config` file to use the `1.0.1` patch version of `ReferencedLibrary` instead of the `1.0.0` version it was originally compiled with.


I would reference the section above where you talk about how to ensure binary compatibility.

BillWagner · 2016-11-25T23:34:22Z

docs/csharp/versioning.md

+
+### new
+
+You use the `new` modifier to hide inherited members of a base class. This ensures resiliency of derived classes allowing you to update base classes the way you want in your library.


The second sentence ready very awkward to me.

Updated the sentence

BillWagner · 2016-11-25T23:35:42Z

docs/csharp/versioning.md

+```
+
+The `override` modifier is evaluated at compile time as opposed to at runtime for the `new` modifier, and the compiler will throw an error
+if it doesn't find a virtual member to override.


Here, as well, you need a good conclusion about what you covered.

I've added a conclusion although I don't think what I wrote gives the article a strong ending. A recommendation will be appreciated

svick · 2016-11-29T16:44:00Z

docs/csharp/versioning.md

+ms.assetid: aa8732d7-5cd0-46e1-994a-78017f20d861
+---
+
+# Versioning in C#


This should be # Versioning in C# #, otherwise the # will not be visible.

svick · 2016-11-29T16:52:01Z

docs/csharp/versioning.md

+* `MINOR` is incremented when you add functionality in a backwards-compatible manner
+* `PATCH` is incremented when you make backwards-compatible bug fixes
+
+There are also ways to specify other scenarios like pre-release versions etc. Go [here](http://semver.org/) to get more information on SemVer


I believe Go [here] is generally not considered a good style for links. Instead, I would link a relevant phrase, like "Semantic versioning" here or "the app.config file" below.

svick · 2016-11-29T16:59:51Z

docs/csharp/versioning.md

+
+* Virtual methods: When you make a virtual method non-virtual in your new version it means that projects that override that method
+will have to be updated.
+* Method signatures: When updating a method behaviour requires you to change it's signature as well, you should instead create an override so that derived classes calling into that method will still work.


Typo: it's → its

svick · 2016-11-29T17:02:54Z

docs/csharp/versioning.md

+
+* Virtual methods: When you make a virtual method non-virtual in your new version it means that projects that override that method
+will have to be updated.
+* Method signatures: When updating a method behaviour requires you to change it's signature as well, you should instead create an override so that derived classes calling into that method will still work.


you should instead create an override

Did you mean "overload" instead of "override"? And why are you mentioning derived classes, doesn't this apply to any class that calls the method? Maybe I just don't understand what are you trying to say here.

I did mean overload thanks for pointing that out. My mention of derived classes was me coming from the angle of inheritance, it definitely makes sense to mention all code that calls into that method. Thanks

svick · 2016-11-29T17:20:03Z

docs/csharp/versioning.md

+* Optional Method Arguments: When you make previously optional method arguments compulsory then all code that does not supply those arguments will need to be updated.
+On the other hand making compulsory arguments optional should have very little effect especially if it doesn't change the method's behaviour.
+* Obsolete attribute: You can use this attribute in your code to specify classes or class members that are deprecated and likely to be removed in future versions.
+This ensures developers utilizing your library are better prepared for breaking changes. More info on the `Obsolete` attribute [here](https://msdn.microsoft.com/en-us/library/22kk2b44(v=vs.90).aspx).


I think this should link to docs.MS instead of MSDN. And I would avoid using [here] as well. The two changes put together:

* [Obsolete attribute](programming-guide/concepts/attributes/common-attributes.md#Obsolete): You can use this attribute …

svick · 2016-11-29T17:49:22Z

docs/csharp/versioning.md

+
+```
+[!code-csharp[Sample usage of the 'new' modifier](/samples/csharp/versioning/new/Program.cs#sample)]
+```


This won't work. Include syntax should not be encodes in triple backticks. And then the link should be relative:

[!code-csharp[Sample usage of the 'new' modifier](../../samples/csharp/versioning/new/Program.cs#sample)]

You can verify this yourself by building the docs using docfx.

svick · 2016-11-29T17:50:57Z

docs/csharp/versioning.md

+[!code-csharp[Sample usage of the 'new' modifier](/samples/csharp/versioning/new/Program.cs#sample)]
+```
+
+#### Output


I wouldn't use a heading for this, since the text after the output does not belong under the heading.

I've made it a bold text

svick · 2016-11-29T17:53:25Z

docs/csharp/versioning.md

+
+### override
+
+The `override` modifier works very similar to the `new` modifier except that it extends the implementation of a base class member rather than


I wouldn't say that it's very similar, the two modifiers are almost opposites.

svick · 2016-11-29T17:55:03Z

docs/csharp/versioning.md

+Derived Method One: Derived Method One
+```
+
+The `override` modifier is evaluated at compile time as opposed to at runtime for the `new` modifier, and the compiler will throw an error


I don't understand what is this trying to say. How is new evaluated at runtime?

To my understanding the compiler checks that there's a suitable method to override and replaces that during compile time whereas the CLR determines what method to run (based on the new modifier) when it encounters conflicting member names between the base and derived class. Perhaps, I could've put it a better way?

The CLR does not decide anything for calls to methods that are not virtual. It does not even know about the new keyword, that basically exists just to hide a warning.

🤔 Then I guess I've been thinking about it all wrong then. Thanks for setting me in the right direction, I'll go ahead an rephrase that sentence.

tonerdo · 2016-12-03T22:14:06Z

@BillWagner @svick Many thanks for your reviews, I've addressed your feedback on my last update. The content is ready for another look over.

svick · 2016-12-03T22:16:53Z

docs/csharp/versioning.md

-Go [here](https://msdn.microsoft.com/en-us/library/7wd6ex19(v=vs.110).aspx) to get more information on redirecting assembly versions.
+> [!NOTE]
+> This approach will only work if the new version of `ReferencedLibrary` is binary compatible with your app.
+> See the `Backwards Compatibility` section above for changes to look out for when determining compatibility.


Backtics shouldn't be used here, since it's not code. And since you're referencing a previous section, it would be nice to make it a link:

> See the [Backwards Compatibility](#backwards-compatibility) section above …

dotnet-bot · 2016-12-03T22:23:29Z

⚠️ Validation status: warnings

File	Status	Preview URL	Details
docs/csharp/versioning.md	⚠️Warning	View	Details
docs/toc.md	✅Succeeded	View

docs/csharp/versioning.md

Line 52: [Warning] Invalid file link:(~/docs/csharp/programming-guide/concepts/attributes/common-attributes.md#Obsolete).

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

dotnet-bot · 2016-12-03T22:47:56Z

✅ Validation status: passed

File	Status	Preview URL	Details
docs/csharp/versioning.md	✅Succeeded	View
docs/toc.md	✅Succeeded	View

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

dotnet-bot · 2016-12-04T20:29:09Z

✅ Validation status: passed

File	Status	Preview URL	Details
docs/csharp/versioning.md	✅Succeeded	View
docs/toc.md	✅Succeeded	View

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

BillWagner · 2017-01-06T20:32:21Z

@tsolarin I'm sorry I let this drop. I thought I had responded to the last version, and I see there were updates since my last review. Please accept my apologies. I'm reviewing it now. 😞

BillWagner

This is getting much closer.

I left a few items, but then it's ready.

BillWagner · 2017-01-06T20:40:07Z

docs/csharp/versioning.md

+
+Here are some things to consider when trying to maintain backwards compatibility with older versions of your library:
+
+* Virtual methods: When you make a virtual method non-virtual in your new version it means that projects that override that method


I'd be more prescriptive here. I think it is safe to say that is such a breaking change that this should be strongly discouraged.

BillWagner · 2017-01-06T20:51:45Z

docs/csharp/versioning.md

+### new
+
+You use the `new` modifier to hide inherited members of a base class.
+This makes your derived classes immune to changes made to the inherited members of the base class


I'd reword this. Instead of "makes your derived classes immune to changes...", I'd say "is one way derived classes can respond to updates in base classes."

BillWagner · 2017-01-06T20:54:31Z

docs/csharp/versioning.md

+
+### override
+
+The `override` modifier is the opposite of the `new` modifier, it extends the implementation of a base class member rather than


I wouldn't say that override is the opposite of new. I'd just say:

"The override modifier means a derived implementation extends the implementation of a base class member..."

BillWagner · 2017-01-06T20:55:11Z

docs/csharp/versioning.md

+### override
+
+The `override` modifier is the opposite of the `new` modifier, it extends the implementation of a base class member rather than
+hides it, also the base class member needs to have the `virtual` modifier applied to it.


I'd split this into two sentences. Starting the second with "The base class member needs..."

BillWagner · 2017-01-06T20:56:55Z

docs/csharp/versioning.md

+keywords: .NET, .NET Core, C#
+author: tsolarin
+manager: wpickett
+ms.date: 2016/12/03


This needs to be mm/dd/yyyy format or the published site shows the wrong date. (I know I gave you this format, but it's a bug we've since discovered.)

tonerdo · 2017-01-08T21:35:43Z

No worries @BillWagner, I've also been quite busy as well. I've made the changes you requested

BillWagner · 2017-01-09T17:17:59Z

Thanks for all the work on this @tsolarin We really appreciate it. This looks great. I'll now.

tonerdo · 2017-01-09T18:08:17Z

Thanks to you too @BillWagner. I'm glad I can be of help

tonerdo · 2017-02-13T13:52:25Z

@BillWagner there seems to be a lot of work to do and I'm quite confused what to tackle next. Can you make a suggestion based on set priorities and milestones?

BillWagner · 2017-02-19T01:50:02Z

@tsolarin I'd look at the current month's milestone and look for any issues with the "Jump In' tag. If none of those are interesting, look for any with the P0 or P1 tag that are unassigned.

dnfclas added the cla-already-signed label Nov 1, 2016

tonerdo added 4 commits November 1, 2016 16:40

add article outline

00e94a9

flesh out content for virtual modifier

50bcb95

flesh out content for override modifier

5022a13

flesh out content for new modifier

ecc0430

tonerdo force-pushed the versioning branch from 1de14e5 to ecc0430 Compare November 1, 2016 15:41

BillWagner added the WIP label Nov 6, 2016

add documentation metadata

5233d66

tonerdo added 3 commits November 11, 2016 00:13

complete second draft based on PR feedback

d3122ee

add versioning to toc

bf71a4d

include code samples

1db8f6a

fix broken SemVer link

bd82827

address PR feedback

a5ac5a5

BillWagner requested changes Nov 25, 2016

View reviewed changes

svick reviewed Nov 29, 2016

View reviewed changes

tonerdo added 2 commits December 3, 2016 23:09

address PR feedback

491a883

Merge branch 'master' into versioning

29010b7

svick reviewed Dec 3, 2016

View reviewed changes

address PR feedback

4fab286

BillWagner removed the WIP label Jan 6, 2017

BillWagner reviewed Jan 6, 2017

View reviewed changes

address PR feedback

80c07b5

BillWagner approved these changes Jan 9, 2017

View reviewed changes

BillWagner merged commit 6308e17 into dotnet:master Jan 9, 2017


		### Assembly Binding Redirection

		You can use the `app.config` file to update the version of a library your app uses. By adding what is called a `binding redirect` your


		### new

		You use the `new` modifier to hide inherited members of a base class. This ensures resiliency of derived classes allowing you to update base classes the way you want in your library.


		### override

		The `override` modifier works very similar to the `new` modifier except that it extends the implementation of a base class member rather than


		Here are some things to consider when trying to maintain backwards compatibility with older versions of your library:

		* Virtual methods: When you make a virtual method non-virtual in your new version it means that projects that override that method


		### override

		The `override` modifier is the opposite of the `new` modifier, it extends the implementation of a base class member rather than

C# Versioning #1197

C# Versioning #1197

Conversation

tonerdo commented Nov 1, 2016

saldana commented Nov 1, 2016

saldana commented Nov 1, 2016

BillWagner commented Nov 4, 2016

BillWagner commented Nov 6, 2016

BillWagner commented Nov 6, 2016

tonerdo commented Nov 6, 2016

BillWagner commented Nov 6, 2016 • edited Loading

saldana commented Nov 6, 2016

tonerdo commented Nov 10, 2016

saldana commented Nov 10, 2016

❌ Validation status: errors

saldana commented Nov 11, 2016

❌ Validation status: errors

BillWagner commented Nov 11, 2016

BillWagner commented Nov 14, 2016

tonerdo commented Nov 15, 2016

tonerdo commented Nov 21, 2016

saldana commented Nov 21, 2016

✅ Validation status: passed

BillWagner commented Nov 23, 2016

BillWagner left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tonerdo Dec 3, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tonerdo Dec 3, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tonerdo Dec 3, 2016 • edited Loading

Choose a reason for hiding this comment

tonerdo commented Dec 3, 2016

Choose a reason for hiding this comment

dotnet-bot commented Dec 3, 2016

⚠️ Validation status: warnings

dotnet-bot commented Dec 3, 2016

✅ Validation status: passed

dotnet-bot commented Dec 4, 2016

✅ Validation status: passed

BillWagner commented Jan 6, 2017

BillWagner left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tonerdo commented Jan 8, 2017

BillWagner commented Jan 9, 2017

tonerdo commented Jan 9, 2017

tonerdo commented Feb 13, 2017

BillWagner commented Feb 19, 2017

BillWagner commented Nov 6, 2016 •

edited

Loading

tonerdo Dec 3, 2016 •

edited

Loading

tonerdo Dec 3, 2016 •

edited

Loading

tonerdo Dec 3, 2016 •

edited

Loading