Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new resource naming article #18307

Merged
merged 8 commits into from
May 11, 2020
Merged

Add new resource naming article #18307

merged 8 commits into from
May 11, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented May 7, 2020 •
edited
Loading

@dotnet-bot dotnet-bot added this to the May 2020 milestone May 7, 2020
@gewarren gewarren marked this pull request as draft May 8, 2020 22:58
@gewarren gewarren changed the title Add EmbeddedResourceUseDependentUponConvention Add new resource naming article May 9, 2020
@gewarren gewarren marked this pull request as ready for review May 9, 2020 00:42
@gewarren gewarren requested a review from a team as a code owner May 9, 2020 00:42
IEvangelist
IEvangelist approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :shipit:

rainersigwald
rainersigwald approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ghogen

docs/core/project-sdk/msbuild-props.md Outdated Show resolved Hide resolved
docs/core/resources/manifest-file-names.md Outdated Show resolved Hide resolved
@gewarren @rainersigwald
Apply suggestions from Rainer
dfc3f8a 
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@gewarren
Copy link
Contributor Author

Thanks for reviewing, David and Rainer!

@benvillalobos
Copy link
Member

Should the section for EmbeddedResourceUseDependentUponConvention link to the more detailed docs page?

@gewarren gewarren requested a review from tdykstra as a code owner May 11, 2020 23:17
@gewarren
Copy link
Contributor Author

Should the section for EmbeddedResourceUseDependentUponConvention link to the more detailed docs page?

Thanks, yes, I added a link.

@gewarren gewarren merged commit e7add3d into dotnet:master May 11, 2020
@gewarren gewarren deleted the resources2 branch May 11, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@rainersigwald rainersigwald rainersigwald approved these changes

@benvillalobos benvillalobos Awaiting requested review from benvillalobos

@tdykstra tdykstra Awaiting requested review from tdykstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
May 2020
Development

Successfully merging this pull request may close these issues.

Add new article on how resource files are named in .NET Core
6 participants
@gewarren @benvillalobos @rainersigwald @IEvangelist @BillWagner @dotnet-bot