-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build suggestions that will become warnings next month #19929
Conversation
Youssef1313
commented
Aug 10, 2020
Co-authored-by: David Pine <david.pine@microsoft.com>
@@ -8,7 +8,7 @@ helpviewer_keywords: | |||
- "deterministic compiler option [C#]" | |||
- "/deterministic compiler option [C#]" | |||
--- | |||
# -deterministic | |||
# -deterministic compiler option (C#) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to add this suffix to all compiler options for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
@@ -5,7 +5,7 @@ ms.date: 02/27/2020 | |||
ms.assetid: a440704c-9e88-4c75-97dd-bfe30ca0fb97 | |||
--- | |||
|
|||
# Arrays | |||
# Arrays in C\# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to add this suffix to all articles in tour-of-csharp for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think this is common enough.
@@ -3,7 +3,7 @@ title: Arrays | |||
description: Learn how to create and use arrays in the F# programming language. | |||
ms.date: 05/16/2016 | |||
--- | |||
# Arrays | |||
# Arrays in F\# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to add this suffix to all articles in F# reference for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, but pinging @cartermp for his opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
@@ -8,7 +8,8 @@ helpviewer_keywords: | |||
- "empty arrays" | |||
ms.assetid: 66a1b3d8-6f3f-4715-b235-e1ff95e32d8e | |||
--- | |||
# Arrays | |||
# Arrays design guidelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to add this suffix to all design guidelines articles for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no, because this is copyrighted content.
@@ -6,7 +6,7 @@ helpviewer_keywords: | |||
- "-deterministic compiler option [Visual Basic]" | |||
- "-deterministic compiler option [Visual Basic]" | |||
--- | |||
# -deterministic | |||
# -deterministic compiler option (Visual Basic) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to add this suffix to all VB compiler options for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
@Youssef1313 Is this something you still want to work on? If not, let's close it. |
Given that a few months passed and it didn't become warnings, I'm going to close. |